Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] edi_oca: Migration to 17.0 #47

Merged
merged 306 commits into from
Jun 28, 2024
Merged

[17.0][MIG] edi_oca: Migration to 17.0 #47

merged 306 commits into from
Jun 28, 2024

Conversation

john-herholz-dt
Copy link
Contributor

@john-herholz-dt john-herholz-dt commented Dec 21, 2023 •
edited
Loading

A lot of views needed to be adjusted.

Furthermore I changed the _search method on edi_exchange_record, as the count param no longer works.
Not sure about the change as I don't know what the override of the _search method was suppossed to do.

Edit: @nguyenminhchien helped on the _search method.

@john-herholz-dt john-herholz-dt mentioned this pull request Dec 21, 2023
Open
7 tasks
nguyenminhchien
nguyenminhchien suggested changes Dec 22, 2023
View reviewed changes
Copy link

@nguyenminhchien nguyenminhchien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR of base_edi has been merged, you can remove it from test-requirements.txt

edi_oca/__manifest__.py Outdated Show resolved Hide resolved
edi_oca/migrations/16.0.1.0.0/pre-migrate.py Outdated Show resolved Hide resolved
edi_oca/models/edi_exchange_record.py Outdated Show resolved Hide resolved
edi_oca/models/edi_exchange_record.py Outdated Show resolved Hide resolved
edi_oca/static/src/xml/widget_edi.xml Outdated Show resolved Hide resolved
edi_oca/views/edi_exchange_type_rule_views.xml Outdated Show resolved Hide resolved
edi_oca/views/edi_exchange_type_views.xml Show resolved Hide resolved
@john-herholz-dt
Copy link
Contributor Author

Thanks @nguyenminhchien for your in depth review. Will adjust everything later today.
Sure I might have forgotten about some essential changes like the name_get. I didn't look into it.

@john-herholz-dt john-herholz-dt force-pushed the 17.0-mig-edi_oca branch 4 times, most recently from e6d02f2 to cce2c95 Compare December 22, 2023 12:20
@john-herholz-dt
Copy link
Contributor Author

I have applied the suggested changes, all tests now pass.

@etobella etobella mentioned this pull request Jan 9, 2024
Merged
@john-herholz-dt
Copy link
Contributor Author

Hello @simahawk , I know you are busy, but once you have some minutes, could you check this PR, I need to migrate everything to 17.0 and edi_oca is the most critical.

I also saw there was another PR for 16 "add partner form page". Do I need to update the code?
Does this work with the git patch command from the migration wiki?

Thank you very much!

simahawk and others added 17 commits January 18, 2024 09:12
@simahawk @john-herholz-dt
edi: move and rename _exchange_notify_record to exc rec
75d6d16 
Notify the related record belongs now to the exchange record itself
as it makes more sense. It has been renamed for better meaning
to '_notify_related_record'.
@simahawk @john-herholz-dt
edi.backend: rename check method for exchange_process
c1a2ca4
@oca-travis @john-herholz-dt
[UPD] Update edi.pot
fd72480
@OCA-git-bot @john-herholz-dt
edi 13.0.1.9.0
3a6eacc
@simahawk @john-herholz-dt
edi: simply ack handling
bbf7af4 
ACK is now provided by a specific type of exchange
and relies on the relation between records of given type.
@simahawk @john-herholz-dt
edi.backend: handle reception of files
717e62f
@simahawk @john-herholz-dt
edi: rename test file for process
17f3159
@simahawk @john-herholz-dt
edi: cron tests silent logger
d407dc0
@simahawk @john-herholz-dt
edi: cron generate ack record when needed
d298104
@oca-travis @john-herholz-dt
[UPD] Update edi.pot
b544ef6
@OCA-git-bot @john-herholz-dt
edi 13.0.1.10.0
74b780b
@simahawk @john-herholz-dt
edi.backend fix _check_input_exchange_sync signature
62889a1
@oca-travis @john-herholz-dt
[UPD] Update edi.pot
88d6b03
@OCA-git-bot @john-herholz-dt
edi 13.0.1.11.0
147babe
@simahawk @john-herholz-dt
edi: add receive component base mixin
2ac31a5
@simahawk @john-herholz-dt
edi: add type advanced settings
398c3de
@simahawk @john-herholz-dt
edi: fix manifest description
dba6da9
@simahawk simahawk self-requested a review February 1, 2024 16:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 2, 2024
@john-herholz-dt
Copy link
Contributor Author

@simahawk what are we doing with this?

JordiMForgeFlow
JordiMForgeFlow approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 9, 2024
@peluko00
Copy link

Can you rebase please for the runboat @john-herholz-dt ?

@john-herholz-dt john-herholz-dt force-pushed the 17.0-mig-edi_oca branch 2 times, most recently from fce214c to b9793f7 Compare June 20, 2024 13:39
@john-herholz-dt
Copy link
Contributor Author

I did the rebase, somehow it had now problems with the pre-commit checks, I did another one pre-commit on my side

@peluko00
Copy link

peluko00 commented Jun 20, 2024 •
edited
Loading

the last commit will be include with the migration commit

I did the rebase, somehow it had now problems with the pre-commit checks, I did another one pre-commit on my side

@peluko00 peluko00 mentioned this pull request Jun 20, 2024
Merged
peluko00
peluko00 approved these changes Jun 20, 2024
View reviewed changes
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-47-by-gurneyalex-bump-nobump, awaiting test results.

@john-herholz-dt
Copy link
Contributor Author

Finally! Jeehaaaa.

@OCA-git-bot OCA-git-bot merged commit 28c097c into OCA:17.0 Jun 28, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 91b3a7f. Thanks a lot for contributing to OCA. ❤️

@john-herholz-dt john-herholz-dt deleted the 17.0-mig-edi_oca branch June 28, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peluko00 peluko00 peluko00 approved these changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

@nguyenminhchien nguyenminhchien nguyenminhchien approved these changes

@simahawk simahawk Awaiting requested review from simahawk

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.