[17.0][MIG] edi_oca: Migration to 17.0 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-herholz-dt
force-pushed
the
17.0-mig-edi_oca
branch
from
cb62973
to
72d9eee
Compare
john-herholz-dt
commented
Dec 21, 2023
nguyenminhchien
suggested changes
Dec 22, 2023
|
Thanks @nguyenminhchien for your in depth review. Will adjust everything later today. |
john-herholz-dt
force-pushed
the
17.0-mig-edi_oca
branch
4 times, most recently
from
e6d02f2
to
cce2c95
Compare
|
I have applied the suggested changes, all tests now pass. |
nguyenminhchien
approved these changes
Dec 26, 2023
|
Hello @simahawk , I know you are busy, but once you have some minutes, could you check this PR, I need to migrate everything to 17.0 and edi_oca is the most critical. I also saw there was another PR for 16 "add partner form page". Do I need to update the code? Thank you very much! |
Notify the related record belongs now to the exchange record itself as it makes more sense. It has been renamed for better meaning to '_notify_related_record'.
ACK is now provided by a specific type of exchange and relies on the relation between records of given type.
Select main only as they can be nested into field custom forms. I'm looking at you on v16 :S
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: edi-framework-16.0/edi-framework-16.0-edi_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-16-0/edi-framework-16-0-edi_oca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: edi-framework-16.0/edi-framework-16.0-edi_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-16-0/edi-framework-16-0-edi_oca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: edi-framework-16.0/edi-framework-16.0-edi_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-16-0/edi-framework-16-0-edi_oca/
john-herholz-dt
force-pushed
the
17.0-mig-edi_oca
branch
2 times, most recently
from
be5c45a
to
5bf3c8e
Compare
john-herholz-dt
force-pushed
the
17.0-mig-edi_oca
branch
from
c27e124
to
54cd737
Compare
|
I have re-done the migration with the latest changes from 16.0 branch that were not included previously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of views needed to be adjusted.
Furthermore I changed the _search method on edi_exchange_record, as the count param no longer works.
Not sure about the change as I don't know what the override of the _search method was suppossed to do.
Edit: @nguyenminhchien helped on the _search method.