[16.0][PORT] edi_oca + edi_exchange_template_oca: fwd port changes from edi/14.0 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuocDuong1306
force-pushed
the
16.0-port-edi_exchange_template
branch
from
a97cb3b
to
f42482f
Compare
|
@QuocDuong1306 can you rebase? |
Avoid warning because of duplicated Model field name while installing this module
This reverts commit a5da7ac9a3ca1bdc82f8f8ed2e8afc23592fb286.
Archived rules were not visible on the exc type form.
You can now toggle archived/unarchived directly from exc type form
Send jobs might fail due to an external service being not responsive. If the job is simply failed, a new one will be spawned and might encour in the same error again, possibly leading to an high number of duplicated jobs for the same record. Yet, when a RetryableJobError is raised, the job will be set back into pending state and will be nicely retried based on jobs configuration.
When actions are automated, is nice to see that data has been generated for an exchange on the related record.
The recommended way to execute actions on records is to call `action_exchange_*` on
Instead of waiting for the cron to pass again and send the file chain the 2 jobs so that it gets sent right after generation.
* catch OSError * add debug log
Prevents having duplicated jobs for the same record as far as possible.
Try to send out the file as fast as possible once the content is ready.
The origin record should never been copied. Its values should always be set specifically by a framework action.
Use `name()` because the real element could be namespaced on render leading to mismatch by element type.
Custom kw args for rendering should be injected before snippets are evaluated. This way they are available for the snippet but also the snippet can override any custom param.
exchange_generate now returns status string, not the output.
QuocDuong1306
force-pushed
the
16.0-port-edi_exchange_template
branch
from
f42482f
to
331d90a
Compare
|
Hello @simahawk , I updated |
simahawk
changed the title
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 8e4655b. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on:
Ported from PRs: