Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.travis.yml: fix as per new template #118

Merged
merged 2 commits into from
Jul 25, 2019
Merged

.travis.yml: fix as per new template #118

merged 2 commits into from
Jul 25, 2019

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Jul 25, 2019

Travis in branch 12.0 is broken. Trying to make it green again.

@pedrobaeza pedrobaeza added this to the 12.0 milestone Jul 25, 2019
@astirpe astirpe changed the title .travis.yml: remove old way of installing wkhtmltopdf .travis.yml: run xvfb as service Jul 25, 2019
@astirpe
Copy link
Member Author

astirpe commented Jul 25, 2019

With this patch it seems working.

@pedrobaeza
Copy link
Member

Why not simply remove all the whtlmtopdf stuff like the template? https://github.com/OCA/maintainer-quality-tools/blob/master/sample_files/.travis.yml

@pedrobaeza pedrobaeza merged commit a2671fa into OCA:12.0 Jul 25, 2019
@astirpe astirpe deleted the 12_fix_travis branch July 25, 2019 10:59
@astirpe astirpe changed the title .travis.yml: run xvfb as service .travis.yml: fix as per new template Jul 25, 2019
@astirpe
Copy link
Member Author

astirpe commented Jul 25, 2019

I'm going to backport this patch to V11 and V10.

This was referenced Jul 25, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@astirpe @pedrobaeza