Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] account_invoice_facturx and account_invoice_facturx_py3o #208

Merged
merged 65 commits into from
Nov 23, 2020

Conversation

alexis-via
Copy link
Contributor

Up-port improvements of account_e-invoice_generate from v12 to v13

@gurneyalex
Copy link
Member

@alexis-via akretion#1 fixes the pre-commit checks on travis

'base_facturx',
'base_vat',
],
'external_dependencies': {'python': ['facturx']},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'external_dependencies': {'python': ['facturx']},
'external_dependencies': {'python': ['factur-x']},

In v13 we can put the PyPI package name here.

'maintainers': ['alexis-via'],
'website': 'https://github.com/OCA/edi',
'depends': ['account_invoice_facturx', 'report_py3o'],
'external_dependencies': {'python': ['facturx']},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'external_dependencies': {'python': ['facturx']},
'external_dependencies': {'python': ['factur-x']},

@pedrobaeza
Copy link
Member

FYI, Odoo has included UNECE codes in v14 for core factur-x.

@alexis-via
Copy link
Contributor Author

Seems I forgot the PR for base_facturx... I have it on my laptop, I'll do the PR soon.

@alexis-via
Copy link
Contributor Author

@pedrobaeza Great, at last. I need to have a look at it.
Their Factur-x implementation is so broken in v13... there is not even the invoice number in factur-x.xml !!! Even once it is fixed, their XML doesn't comply with the XSD... it's a shame.

@pedrobaeza
Copy link
Member

Ouch, that's a shame... I think proper bug reports can guide the situation to be fixed.

@alexis-via
Copy link
Contributor Author

@pedrobaeza I found these issues a few days ago. I'll try to find some time in the coming days to make some bug reports.

@alexis-via
Copy link
Contributor Author

Depends on PR to migrate base_facturx #209

Rename account_invoice_import_zugferd to account_invoice_import_factur-x
Add module to support py3o reporting engine:
…xist in v10) in account_invoice_factur-x and account_invoice_ubl
Make country_id field required on res.partner form view
Add support for start/end dates on lines
Better handling of invalid IBANs
To avoid headaches with invalid files, now check XSD of XML invoices before parsing it upon import
Move Factur-X/zugferd xsd to base_zugferd
…81 instead of document type = 380 with negative amounts

Improve the code of refund import to support both negative invoices and positive refunds
Add script mass_invoice_import.py
Code cleanup
One of the zugferd-specific code has been standardised in UNECE, so moved to the account_tax_unece module
Billolha and others added 22 commits November 23, 2020 12:12
Currently translated at 100,0% (26 of 26 strings)

Translation: edi-10.0/edi-10.0-account_invoice_factur-x
Translate-URL: https://translation.odoo-community.org/projects/edi-10-0/edi-10-0-account_invoice_factur-x/fr/
Updated by Actualizar ficheiros PO com o novo POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (26 of 26 strings)

Translation: edi-10.0/edi-10.0-account_invoice_factur-x
Translate-URL: https://translation.odoo-community.org/projects/edi-10-0/edi-10-0-account_invoice_factur-x/de/
Currently translated at 100.0% (1 of 1 strings)

Translation: edi-10.0/edi-10.0-account_invoice_factur-x_py3o
Translate-URL: https://translation.odoo-community.org/projects/edi-10-0/edi-10-0-account_invoice_factur-x_py3o/de/
MIG account_invoice_facturx_py3o to v13
Up-port improvements of account_e-invoice_generate from v12 to v13
extract a method from _cii_add_invoice_line_block to lower the
complexity rating of that method and get a green check.
as suggested by Stéphane Bidoul
@etobella
Copy link
Member

@alexis-via This PR makes runbot fail, Can you review?

@alexis-via
Copy link
Contributor Author

Yes. But when I connect to runbot, I don't get any error in the logs, only some INFO messages. Maybe I don't know how to use Runbot properly. Do you know where I can see an error message ?

@etobella
Copy link
Member

This module excludes a base module that will be autoinstalled by odoo. This modules and the dependent modules cannot be tested on travis

@etobella
Copy link
Member

Adding the exclude has made uninstallable 6 modules. Just wondering if we need to revert this PR and propose a new PR without this issue. At the end, this will be a lot of code that will not be tested by CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.