Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] Add edi_sale_oca + edi_sale_ubl_oca #759

Closed
wants to merge 52 commits into from

Conversation

simahawk
Copy link
Contributor

@simahawk simahawk commented May 11, 2023

Provide full cycle for inbound Order + outbound OrderResponse.
These modules are now deprecated in favour of a more organic edi_sale_oca + edi_sale_ubl_oca:

  • edi_sale_order_import
  • edi_sale_order_import_ubl
  • edi_sale_order_import_ubl_endpoint

Depends on:

TODO:

  • split PR by module
  • document

@simahawk simahawk force-pushed the 14-edi-ubl-order-response branch 2 times, most recently from 7d45d64 to a3209eb Compare May 19, 2023 07:47
@simahawk simahawk force-pushed the 14-edi-ubl-order-response branch 3 times, most recently from 119b59e to c2ac8c0 Compare June 1, 2023 09:32
@simahawk
Copy link
Contributor Author

Splitting edi_sale_oca + endpoint to #831 and removing dependency on _auto

@QuocDuong1306
Copy link

Hi @simahawk , should we need to move listeners.py in edi_sale_ubl_oca to edi_sale_oca for common?
Because in the future, maybe we need more modules like edi_sale_ubl_oca (ex: edi_sale_edifact_oca,...)

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 18, 2024
qty = self.product_uom_qty
if not qty:
return self.order_id.EDI_STATE_ORDER_LINE_NOT_ACCEPTED
if qty > vals["product_uom_qty"] or qty < vals["product_uom_qty"]:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: consider comparing available qty. This can come from sale_stock_available_to_promise_release so we need an hook for a glue module just for the qty comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically. work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants