Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0][WIP][event_product_logistics] Manage product delivery for event attendees #23

Closed
wants to merge 9 commits into from
Closed

Conversation

yajo
Copy link
Member

@yajo yajo commented Dec 29, 2015

As asked by @dreispt in #21 (comment), I'm opening this PR. Bots will fail until #21 is merged. Target: OCA/l10n-spain#174. Design as discussed in #14.

Sometimes you want to give some products to your event's attendees. For example: a pen, a notebook, a book, etc.

This module extends the functionality of events to support setting products to deliver to event attendees and allow you to know if they have been already delivered to them.

example: a pen, a notebook, a book, etc.

This module extends the functionality of events to support setting products to
deliver to event attendees and allow you to know if they have been already

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have already been

@dreispt dreispt added this to the 8.0 milestone Feb 17, 2016
"name": "Product Delivery in Events",
"summary": "Deliver products to event attendees",
"version": "8.0.1.0.0",
"category": "Events",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this shouldn0t be "Event Management". Can you check?

@dreispt
Copy link
Member

dreispt commented Feb 17, 2016

I have two main design questions:

  • Why depend on event_product? AFAICS that could be avoided.
  • Why the two modules? The second one repeats code from the first. Maybe it could depend on the first to avoid such repetition.

@yajo
Copy link
Member Author

yajo commented Feb 17, 2016

Yikes, I forgot to remove the old module! Thanks!

The relation between events and products in this module can be seen in method action_load_deliverable_products, where you can load that information from the linked product.

Indeed, I could just create 2 modules instead of one, but the second would be so small that I decided to avoid that for simplicity, but if you feel it's necessary I can split it.

@dreispt
Copy link
Member

dreispt commented Feb 17, 2016

No need to split.
I have the feeling that the event_product dependency can be avoided. What do you think?

@yajo
Copy link
Member Author

yajo commented Feb 17, 2016

Normally, if e.g. your event is from product Odoo onsite training, you know you will give away notebook, pen and Odoo t-shirt. If you cannot define that in the product, you need to choose them manually in every event.

With current implementation, you give the user the chance to edit the deliverable products in the event, but to do it in the product to avoid repetition too.

How do you think we can get this without depending on event_product?

@dreispt
Copy link
Member

dreispt commented Feb 17, 2016

Instead of adding event_deliverable_product_ids to product.template, add it directly to event.event.
AFAICS all the rest should work.

@yajo
Copy link
Member Author

yajo commented Feb 17, 2016

It already has it.

@dreispt
Copy link
Member

dreispt commented Feb 17, 2016

So the same field is in the two models?
I'm confused; what's the point?

@yajo
Copy link
Member Author

yajo commented Feb 17, 2016

I think it will be clearer if you try it. Please open the runbot and follow all the steps in the usage section of the readme. Then please tell me what you don't understand.

@dreispt
Copy link
Member

dreispt commented Feb 17, 2016

OK, will try that.

@dreispt
Copy link
Member

dreispt commented Feb 17, 2016

I see the point.
In theory we could split the product-side features into another module, but as you say, in practice it would probably be an overkill. So OK: 👍

@dreispt dreispt removed the question label Feb 17, 2016
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 12, 2021
@github-actions github-actions bot closed this Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants