-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0][WIP][event_product_logistics] Manage product delivery for event attendees #23
Conversation
example: a pen, a notebook, a book, etc. | ||
|
||
This module extends the functionality of events to support setting products to | ||
deliver to event attendees and allow you to know if they have been already |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have already been
Although it means making tests weaker.
Instead of creating a page, it uses the one created by base module.
"name": "Product Delivery in Events", | ||
"summary": "Deliver products to event attendees", | ||
"version": "8.0.1.0.0", | ||
"category": "Events", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this shouldn0t be "Event Management". Can you check?
I have two main design questions:
|
Yikes, I forgot to remove the old module! Thanks! The relation between events and products in this module can be seen in method Indeed, I could just create 2 modules instead of one, but the second would be so small that I decided to avoid that for simplicity, but if you feel it's necessary I can split it. |
No need to split. |
Normally, if e.g. your event is from product Odoo onsite training, you know you will give away notebook, pen and Odoo t-shirt. If you cannot define that in the product, you need to choose them manually in every event. With current implementation, you give the user the chance to edit the deliverable products in the event, but to do it in the product to avoid repetition too. How do you think we can get this without depending on |
Instead of adding |
So the same field is in the two models? |
I think it will be clearer if you try it. Please open the runbot and follow all the steps in the usage section of the readme. Then please tell me what you don't understand. |
OK, will try that. |
I see the point. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
As asked by @dreispt in #21 (comment), I'm opening this PR. Bots will fail until #21 is merged. Target: OCA/l10n-spain#174. Design as discussed in #14.
Sometimes you want to give some products to your event's attendees. For example: a pen, a notebook, a book, etc.
This module extends the functionality of events to support setting products to deliver to event attendees and allow you to know if they have been already delivered to them.