[16.0][MIG] event_registration_partner_unique: Migration to version 16.0 #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinafernandez-tecnativa
force-pushed
the
16.0-mig-event_registration_partner_unique
branch
5 times, most recently
from
6bac255
to
d2c9632
Compare
|
ping @pedrobaeza |
|
/ocabot migration event_registration_partner_unique |
pedrobaeza
approved these changes
Oct 2, 2023
|
ping @pedrobaeza |
|
You have to rebase and remove the extra temporary commit. |
This module allows you to avoid having a partner registrated twice in the same event.
It has to declare unique indexes instead of constraints to work. [1]: OCA#38 (comment)
- Remove dependency on event_sale. - Add custom field that allows to choose in which events to disable duplicates. - Add tests. - Add custom exception to be used in upcoming submodule (for event_sale).
- Updated views - Updated README
Currently translated at 100.0% (5 of 5 strings) Translation: event-13.0/event-13.0-event_registration_partner_unique Translate-URL: https://translation.odoo-community.org/projects/event-13-0/event-13-0-event_registration_partner_unique/es/
Steps to reproduce the problem: - Register anonymously a first attendee for an event from website. - The registration is saved with no attendee_partner_id. - Repeat the registration again anonymously. - You get the error "Duplicated partners found in event...". That's because current duplicated domain is searching for other registrations regardless of if there's a linked partner or not. We now restrict the search to those with a linked partner. TT32961
carolinafernandez-tecnativa
force-pushed
the
16.0-mig-event_registration_partner_unique
branch
from
b7de8bd
to
31d9680
Compare
Done! |
|
This PR has the |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 0241ce0. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa
TT45229
@pedrobaeza @chienandalu