Make no type count as a type. #36
Conversation
Fix #35. When an event had no type, it was not getting in the mapping because of the way Odoo generates recordsets.
| _("You cannot cancel registrations from events of different " | ||
| "types at once.")) | ||
| res['event_type_id'] = event_type.id | ||
| first_type = registrations[0].event_id.type |
There was a problem hiding this comment.
Put registrations[:1]to avoid errors in case of 0 registrations.
There was a problem hiding this comment.
Not sure, but making your code bullet-proof is always better
There was a problem hiding this comment.
Yes, I know, but I feel an exception here would be the right thing to happen. After all, what registrations are you going to cancel if there are none?
There was a problem hiding this comment.
No, but that doesn't serve for multi...
There was a problem hiding this comment.
I prefer the other formula. It can silently pass to the other window without problems, and it's harmless
There was a problem hiding this comment.
I still cannot find a real use case where you could possibly get to this wizard and registrations would be empty (and less where you'd wish the process not to get interrupted). But nevermind, let me change it.
|
Please tag as "needs review". |
|
👍 |
|
Thanks! 👍 |
|
👍 |
Make no type count as a type.
Fix #35. When an event had no type, it was not getting in the mapping because of the way Odoo generates recordsets.
@rafaelbn @pedrobaeza