[8.0] event contact person

[mikevhe18]

My goal is to create a module that can display the contact person at the event page on the website.
So before I make that module, i make this module which has the function to add the contact person fields in the event. Thanks

[rafaelbn]

Hi @mikevhe18 , Odoo already has this fields, why do you want to duplicate this info?

[mikevhe18]

@rafaelbn it's because sometimes events can have one or more contact person.
The responsible user is different from the contact person. Responsible user is an organization / person who organizes an event, meanwhile the contact person is the person who responsible to be contacted by people

[rafaelbn]

OK, thanks. 👍

Please @yajo take a review here.

[yajo]

Wrong URL, as in all other headers.

[yajo]

Good work overall @mikevhe18, please fix those little details to get approval. Thanks.

[mikevhe18]

Thanks @yajo.
I've made a changes, would you kindly review this PR again ?

[yajo]

Remove the "a"

[andhit-r]

Tested on runbot 👍

[yajo]

👍

[andhit-r]

Hi @OCA/crm-sales-marketing-maintainers . This PR is ready to be merged (3 reviews)

[pedrobaeza]

For me the only problem is the name: you can say the same with the name event_contact, as person is not a relevant part in my opinion. What do you think?

[yajo]

Good point, partners can be companies too.

[andhit-r]

Agree

[mikevhe18]

@pedrobaeza @yajo @andhit-r I've made a changes, please review this module again. Thank You..

[coveralls]

Changes Unknown when pulling 16b88a2 on mikevhe18:8.0-event_contact_person into * on OCA:8.0*.

[pedrobaeza]

Please don't put plurals in module name. The module name should be event_contact

[coveralls]

Changes Unknown when pulling b613fa6 on mikevhe18:8.0-event_contact_person into * on OCA:8.0*.

[pedrobaeza]

The name must be contact_ids, as the plural is only used in the _ids part

[coveralls]

Changes Unknown when pulling 3a22fdc on mikevhe18:8.0-event_contact_person into * on OCA:8.0*.

[yajo]

Finally got it! Thanks 😉 👍

[sergio-teruel]

👍

[rafaelbn]

Thanks 👍