9.0 [MIG] event_email_reminder #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajo
previously requested changes
Nov 17, 2016
|
|
||
| .. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
| :alt: Try me on Runbot | ||
| :target: https://runbot.odoo-community.org/runbot/199/8.0 |
| <!-- © 2016 Sergio Teruel <sergio.teruel@tecnativa.com> | ||
| License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). --> | ||
| <openerp> | ||
| <data noupdate="1"> |
| self, days=7, draft_events=False, near_events=False, | ||
| template_id=None): | ||
| """Enqueue mail with a summary of events that begin on days parameter | ||
| :param int days: number of days to reminder when events star |
| <field name="active" eval="True"/> | ||
| <field name="model" eval="'event.event'"/> | ||
| <field name="function" eval="'run_event_email_reminder'"/> | ||
| <field name="args" eval="'(5, False, False, None)'"/> |
There was a problem hiding this comment.
You add 5 by default here, and 7 in the method. I think it's more consistent to have the same default in both places.
| <field name="args" eval="'(5, False, False, None)'"/> | ||
| <field name="doall" eval="False"/> | ||
| <field name="interval_number">1</field> | ||
| <field name="interval_type">days</field> |
There was a problem hiding this comment.
So everyday you get an email with next events?
Well, I guess you can change that, but seems a bit spamming default. Not blocker though.
pedrobaeza
requested changes
Nov 25, 2016
| :param str template_id: id of a template or None | ||
| """ | ||
| today = fields.Date.context_today(self) | ||
| limit_date = datetime.strptime( |
There was a problem hiding this comment.
Use here fields.Date.from_string()
There was a problem hiding this comment.
This one still remains untouched.
| def setUp(self): | ||
| super(TestEventEmailReminder, self).setUp() | ||
| today = time.strftime(DEFAULT_SERVER_DATE_FORMAT) | ||
| date_event_1 = datetime.strptime( |
[ADD][8.0] event_email_reminder: Send reminder events by email
pedrobaeza
force-pushed
the
9.0-mig-event_email_reminder
branch
from
e737bc3
to
fc92d68
Compare
pedrobaeza
approved these changes
Nov 26, 2016
pedrobaeza
dismissed
yajo’s stale review
He's on holidays are comments have been attended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included:
- Imported last updates from v8
- Adapted to v9
- Fix error on tests
cc @Tecnativa