Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0] [MIG] fleet_vehicle_stock: Migration to 15.0 #104

Merged
merged 16 commits into from
Apr 4, 2023
Merged

[15.0] [MIG] fleet_vehicle_stock: Migration to 15.0 #104

merged 16 commits into from
Apr 4, 2023

Conversation

rodrigonevest
Copy link
Contributor

No description provided.

marcelsavegnago and others added 14 commits March 28, 2023 18:01
@marcelsavegnago @rodrigonevest
[ADD] add fleet_vehicle_stock
91ff314
@OCA-git-bot @rodrigonevest
[UPD] README.rst
795f291
@oca-travis @rodrigonevest
[UPD] Update fleet_vehicle_stock.pot
99c70e1
@marcelsavegnago @rodrigonevest
Added translation using Weblate (Portuguese (Brazil))
32b6a55
@marcelsavegnago @rodrigonevest
Translated using Weblate (Portuguese (Brazil))
83a1160 
Currently translated at 100.0% (19 of 19 strings)

Translation: fleet-12.0/fleet-12.0-fleet_vehicle_stock
Translate-URL: https://translation.odoo-community.org/projects/fleet-12-0/fleet-12-0-fleet_vehicle_stock/pt_BR/
@marcelsavegnago @rodrigonevest
[IMP] fleet_vehicle_stock: black, isort, prettier
de0e046
@marcelsavegnago @rodrigonevest
[MIG] fleet_vehicle_stock: Migration to 13.0
b5682f6
@marcelsavegnago @rodrigonevest
[RFC] fleet_vehicle_stock: test refactor
0c1bef7
@oca-travis @rodrigonevest
[UPD] Update fleet_vehicle_stock.pot
abb17f0
@OCA-git-bot @rodrigonevest
[UPD] README.rst
db8331e
@marcelsavegnago @rodrigonevest
[IMP] fleet_vehicle_stock: black, isort, prettier
0be8ec9
@marcelsavegnago @rodrigonevest
[MIG] fleet_vehicle_stock: Migration to 14.0
660624d
@oca-travis @rodrigonevest
[UPD] Update fleet_vehicle_stock.pot
b59d533
@OCA-git-bot @rodrigonevest
[UPD] README.rst
1040745
@rodrigonevest rodrigonevest marked this pull request as draft March 28, 2023 21:10
@rodrigonevest rodrigonevest marked this pull request as ready for review March 29, 2023 22:32
@rodrigonevest rodrigonevest marked this pull request as draft March 29, 2023 22:35
@rodrigonevest rodrigonevest marked this pull request as ready for review March 29, 2023 22:49
marcelsavegnago
marcelsavegnago requested changes Mar 29, 2023
View reviewed changes
fleet_vehicle_stock/views/fleet_vehicle.xml Outdated
<field name="arch" type="xml">
<xpath expr="//notebook" position="inside">
<notebook>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here we need to define the position inside

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/odoo/odoo/blob/15.0/addons/fleet/views/fleet_vehicle_views.xml#L90

@rodrigonevest rodrigonevest marked this pull request as draft March 29, 2023 22:57
@rodrigonevest rodrigonevest marked this pull request as ready for review March 29, 2023 23:40
@marcelsavegnago
Copy link
Member

@rodrigonevest Could you add more tests so that we can increase the test coverage?

@ivantodorovich
Copy link

LG. Thanks!
Let me know if we wait for the unit tests or not ;)

/ocabot migration fleet_vehicle_stock

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Apr 4, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 4, 2023
Closed
11 tasks
marcelsavegnago
marcelsavegnago approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivantodorovich if you can merge, we add more tests at another time.

@ivantodorovich
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-104-by-ivantodorovich-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 4, 2023
@OCA-git-bot
Merge PR #104 into 15.0
ef6c792 
Signed-off-by ivantodorovich
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 15.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 15.0-ocabot-merge-pr-104-by-ivantodorovich-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5c9ee05 into OCA:15.0 Apr 4, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1870799. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rodrigonevest @marcelsavegnago @ivantodorovich @OCA-git-bot @oca-travis