Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] fleet_vehicle_inspection #26

Merged
merged 6 commits into from
Mar 16, 2021
Merged

[13.0][MIG] fleet_vehicle_inspection #26

merged 6 commits into from
Mar 16, 2021

Conversation

marcelsavegnago
Copy link
Member

No description provided.

@marcelsavegnago marcelsavegnago mentioned this pull request Feb 28, 2021
Merged
@marcelsavegnago marcelsavegnago force-pushed the 13.0-mig-fleet_vehicle_inspection branch from cd1b8c1 to b7aa1ad Compare March 1, 2021 20:17
ivantodorovich
ivantodorovich reviewed Mar 1, 2021
View reviewed changes
Copy link

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

A few comments no really related to the migration, but that would be nice to do

fleet_vehicle_inspection/models/fleet_vehicle_inspection.py Outdated Show resolved Hide resolved
fleet_vehicle_inspection/models/fleet_vehicle_inspection.py Outdated Show resolved Hide resolved
fleet_vehicle_inspection/models/fleet_vehicle_inspection.py Outdated Show resolved Hide resolved
fleet_vehicle_inspection/models/fleet_vehicle_inspection.py Outdated Show resolved Hide resolved
fleet_vehicle_inspection/models/fleet_vehicle_inspection.py Outdated Show resolved Hide resolved
@ivantodorovich
Copy link

Also make sure you've installed pre-commit in your git clone (with pre-commit install) and that you run pre-commit run -a, because travis is failing

@marcelsavegnago marcelsavegnago force-pushed the 13.0-mig-fleet_vehicle_inspection branch 3 times, most recently from 131ce0c to 55a97b1 Compare March 2, 2021 01:46
@ivantodorovich
Copy link

Just need to fix tests and please squash all your migration commits together :)

@marcelsavegnago marcelsavegnago force-pushed the 13.0-mig-fleet_vehicle_inspection branch from 8764638 to 1497fa0 Compare March 7, 2021 22:04
@marcelsavegnago
Copy link
Member Author

@ivantodorovich @mamcode done.

mamcode
mamcode approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@mamcode mamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this migration 👍

@marcelsavegnago
Copy link
Member Author

ping @ivantodorovich 🙏 😄

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@marcelsavegnago
Copy link
Member Author

@OCA/fleet-maintainers, can you merge this PR please :)?

@ivantodorovich
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-26-by-ivantodorovich-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a48720c into OCA:13.0 Mar 16, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6943f4c. Thanks a lot for contributing to OCA. ❤️

@marcelsavegnago marcelsavegnago deleted the 13.0-mig-fleet_vehicle_inspection branch March 16, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian10048 brian10048 brian10048 approved these changes

@mamcode mamcode mamcode approved these changes

@ivantodorovich ivantodorovich Awaiting requested review from ivantodorovich

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcelsavegnago @ivantodorovich @OCA-git-bot @mamcode @brian10048