[12.0][ADD] add fleet_vehicle_fuel_type_ethanol #54
Conversation
marcelsavegnago
force-pushed
the
12.0-add-fleet_vehicle_additional_fuel_type
branch
from
53f2d5e
to
be0c8a1
Compare
There was a problem hiding this comment.
Hmm I'd rename this module as fleet_vehicle_fuel_type_ethanol
Both added fuel types are related to it.
I tried to find the reason why Odoo made this a Selection field rather than a One2many. All I could find is this: https://github.com/odoo/odoo/blob/13004de8adf9578e775017ada85e13c3a2f966e7/addons/l10n_be_hr_payroll_fleet/models/fleet.py#L49
In any case, I don't see any conflicts with this module.. unless you use belgium localization and you want to compute co2 for ethanol cars
| #. module: fleet_vehicle_additional_fuel_type | ||
| #: selection:fleet.vehicle,fuel_type:0 | ||
| msgid "Ethanol" | ||
| msgstr "Ethanol" |
There was a problem hiding this comment.
Translate Ethanol to Etanol.
msgstr "Etanol"
There was a problem hiding this comment.
I removed the translation files because the .pot itself is in gitignore and I ended up forcing it to be included in git. For now, I will wait for the return of @ivan if it is automatically generated and if it is, I will leave it to translate through the weblate.
There was a problem hiding this comment.
Sorry I just read this!
Yes, they are generated by Travis 😊
|
@ivantodorovich Is the .pot file automatically generated when the module is merged? |
marcelsavegnago
force-pushed
the
12.0-add-fleet_vehicle_additional_fuel_type
branch
from
be0c8a1
to
0a10803
Compare
done!
I understood. I'm going to take a look at this module... thanks |
marcelsavegnago
changed the title
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
It looks like something changed on |
|
It looks like something changed on |
|
It looks like something changed on |
|
It looks like something changed on |
|
Congratulations, your PR was merged at b49dd07. Thanks a lot for contributing to OCA. ❤️ |
No description provided.