[12.0][ADD] add fleet_vehicle_pivot_graph

[marcelsavegnago]

No description provided.

[ivantodorovich]

I'm replying to your comment #51 (comment)

Yes, if I create a module to add only the pivot view and another to create add only the graphical view, one will overwrite the record fleet.fleet_vehicle_action created by the other if done as mentioned below:

fleet_vehicle_pivot

    <record id="fleet.fleet_vehicle_action" model="ir.actions.act_window">
        <field name="view_mode">kanban,tree,**pivot**,activity,form</field>
    </record>

fleet_vehicle_graph

    <record id="fleet.fleet_vehicle_action" model="ir.actions.act_window">
        <field name="view_mode">kanban,tree,**graph**,activity,form</field>
    </record>

The alternative would be to implement in both modules the following as mentioned below:

    <record id="fleet.fleet_vehicle_action" model="ir.actions.act_window">
        <field name="view_mode">kanban,tree,**pivot**,**graph**,activity,form</field>
    </record>

If someone implements a module that adds the calendar view, they will overwrite it too.

    <record id="fleet.fleet_vehicle_action" model="ir.actions.act_window">
        <field name="view_mode">kanban,tree,**calendar**,activity,form</field>
    </record>

I can create a single module by adding the pivot table and the graph view. Do you have a suggested name for the module if you think it is the most suitable option?

• fleet_vehicle_additional_view
• fleet_vehicle_pivot_graph
• fleet_vehicle_view_extension
• fleet_usability (generic name)
• fleet_vehicle_usability (generic name)
• fleet_vehicle_report (as suggested by you) (I don't know if it would be the most suitable name but that's fine by me)

The calendar view can also be created, but it lacks a relevant date to use since the vehicle data model has only the vehicle acquisition date and it does not seem valid to implement the calendar view.

Anyway, it is a small problem, but a little boring to deal with in my opinion.

Let's go for this one, it it's ok to you: fleet_vehicle_pivot_graph

I don't like additional, extension or usability because they don't actually say anything.
However I see your point, it's a small and boring problem.

Alternatively a you can achieve that level of compatibility with other modules by using both post_init_hook and uninstall_hook to effectively add and remove those types of views without overwritting the previous values.

But either way is ok by me !

[marcelsavegnago]

Let's go for this one, it it's ok to you: fleet_vehicle_pivot_graph

@ivantodorovich done!

Alternatively a you can achieve that level of compatibility with other modules by using both post_init_hook and uninstall_hook to effectively add and remove those types of views without overwritting the previous values.

Ok .. thanks for the explanation. I'm going to study hooks.

[marcelsavegnago]

ping @mamcode @mymage

[mymage]

I tried to follow your observation on the problem of overwriting extension but I'm not so confident with code to say something. Anyway the result for me is ok.

[ivantodorovich]

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-56-by-ivantodorovich-bump-nobump, awaiting test results.

[OCA-git-bot]

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-56-by-ivantodorovich-bump-nobump, awaiting test results.

[OCA-git-bot]

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-56-by-ivantodorovich-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 7de155c. Thanks a lot for contributing to OCA. ❤️