Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][ADD] add fleet_vehicle_stock #59

Merged
merged 1 commit into from
Apr 13, 2021
Merged

[12.0][ADD] add fleet_vehicle_stock #59

merged 1 commit into from
Apr 13, 2021

Conversation

marcelsavegnago
Copy link
Member

@marcelsavegnago marcelsavegnago commented Apr 4, 2021 •
edited
Loading

This module is an add-on for the Fleet application in Odoo. It allows you to track your Fleet Vehicles in stock moves.

Products can be automatically converted into Fleet Vehicle.
This is only available only for products tracked by serial number.
This needs to be enabled both on Operation Types and Products.
For example, we may want to create the Fleet Vehicle on Delivery,
or on Receipts.

To enable on Products:

  • Go to Inventory > Master Data > Products
  • Open the Product form, Inventory tab
  • On the "Traceability" section, make sure
    "Tracking" is set to "By Unique Serial Number"
  • Enable the "Creates Fleet Vehicle" checkbox
  • Open Fleet tab
  • Select Fleet Vehicle Model

To enable on Operation Types:

  • Go to Inventory > Configuration > Operation Types
  • Select the intended Operation Type ("Receipts" for example)
  • On the "Traceability" section, enable the
    "Create Fleet Vehicle" checkbox

cc @mamcode @ivantodorovich @mymage

@marcelsavegnago marcelsavegnago force-pushed the 12.0-fleet_vehicle_stock branch 8 times, most recently from a9da20c to c29f228 Compare April 6, 2021 01:19
@marcelsavegnago marcelsavegnago marked this pull request as draft April 6, 2021 01:40
@marcelsavegnago marcelsavegnago force-pushed the 12.0-fleet_vehicle_stock branch 2 times, most recently from 8b80cbb to 696b737 Compare April 6, 2021 02:01
@marcelsavegnago marcelsavegnago marked this pull request as ready for review April 6, 2021 02:01
@marcelsavegnago
Copy link
Member Author

@OCA/fleet-maintainers if anyone can review I appreciate it.

ivantodorovich
ivantodorovich requested changes Apr 6, 2021
View reviewed changes
Copy link

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick code review

fleet_vehicle_stock/models/fleet_vehicle.py Outdated Show resolved Hide resolved
fleet_vehicle_stock/models/fleet_vehicle.py Outdated Show resolved Hide resolved
fleet_vehicle_stock/models/fleet_vehicle.py Outdated Show resolved Hide resolved
fleet_vehicle_stock/models/stock_move.py Outdated Show resolved Hide resolved
fleet_vehicle_stock/models/stock_production_lot.py Outdated Show resolved Hide resolved
fleet_vehicle_stock/models/fleet_vehicle.py Outdated Show resolved Hide resolved
@marcelsavegnago marcelsavegnago force-pushed the 12.0-fleet_vehicle_stock branch 2 times, most recently from d790654 to 4bed7e0 Compare April 7, 2021 02:00
@marcelsavegnago
Copy link
Member Author

@mamcode @brian10048 @mymage can you review this PR please :)? it was based on the fieldservice_equipment_stock module.

https://github.com/OCA/field-service/tree/12.0/fieldservice_equipment_stock

@marcelsavegnago
Copy link
Member Author

ping @mamcode @mymage @brian10048

@marcelsavegnago marcelsavegnago force-pushed the 12.0-fleet_vehicle_stock branch 3 times, most recently from 19ba828 to 9b66717 Compare April 12, 2021 20:39
mamcode
mamcode approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@mamcode mamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ivantodorovich
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-59-by-ivantodorovich-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 13, 2021
@OCA-git-bot
Merge PR #59 into 12.0
5a67605 
Signed-off-by ivantodorovich
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-59-by-ivantodorovich-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2af2005 into OCA:12.0 Apr 13, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6a2a8ab. Thanks a lot for contributing to OCA. ❤️

@marcelsavegnago marcelsavegnago deleted the 12.0-fleet_vehicle_stock branch April 13, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@mamcode mamcode mamcode approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcelsavegnago @ivantodorovich @OCA-git-bot @mamcode