Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] hr_expense_payment: Migration to 17.0 #229

Merged
merged 20 commits into from
May 24, 2024

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Apr 4, 2024

Module migrated to version 17.0

cc https://github.com/APSL 148967

@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

Issue: #214

@peluko00 peluko00 mentioned this pull request Apr 4, 2024
7 tasks
@Saran440
Copy link
Member

Saran440 commented Apr 9, 2024

/ocabot migration hr_expense_payment

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Apr 9, 2024
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly, checked in runboat

@peluko00
Copy link
Contributor Author

@Saran440 Please review

@Saran440
Copy link
Member

/ocabot migration hr_expense_payment

Copy link
Member

@lbarry-apsl lbarry-apsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, tested on Runboat

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Saran440
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-229-by-Saran440-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2bb4feb into OCA:17.0 May 24, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 60f388e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.