Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD]Base dns infrastructure #18

Closed
wants to merge 3 commits into from
Closed

[16.0][ADD]Base dns infrastructure #18

wants to merge 3 commits into from

Conversation

flotho
Copy link
Member

@flotho flotho commented Dec 26, 2022

trying a standard port with oca-port

@flotho flotho changed the title [16.0][MIG]connector dns WIP[16.0][MIG]connector dns Dec 26, 2022
@flotho flotho mentioned this pull request Dec 26, 2022
Open
@flotho
Copy link
Member Author

flotho commented Dec 26, 2022

Hi,
I would like to submit for a first review this PR to check if I'm going in the right direction.
@lasley @noahzaozao @ruter-lyu @murtuzasaleh @max3903 @JoJoJoJoJoJoJo all comments would will be appreciated.

The next step will be to create connector modules, I will start with an OVH connector

@flotho
Copy link
Member Author

flotho commented Dec 26, 2022

ping @sbidoul there's an issue during the build and I'm not able to identify the origin.
Regards

@flotho flotho mentioned this pull request Dec 26, 2022
Closed
@flotho
Copy link
Member Author

flotho commented Dec 30, 2022

here is the logs that I can't see what to to from my side :

ERROR: Cannot install odoo<16.1dev and >=16.0a and odoo<9.0a and >=8.0a because these package versions have conflicting dependencies.

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
The conflict is caused by:
    The user requested odoo<16.1dev and >=16.0a
    The user requested odoo<9.0a and >=8.0a

@sbidoul
Copy link
Member

sbidoul commented Dec 30, 2022

Hi @flotho! That is because there is a manifest with version 8.0 in this PR. Addons with such manifest automatically depend on Odoo 8 and pip cannot satisfy that in a 16.0 branch CI.

@flotho
Copy link
Member Author

flotho commented Dec 30, 2022

thanks @sbidoul , I'll check this

@flotho
Copy link
Member Author

flotho commented Jan 4, 2023

Hi @lasley @noahzaozao @ruter-lyu @murtuzasaleh @max3903 @JoJoJoJoJoJoJo

I'm rebooting this repo in v16 with a simple module as a strating point.
Everything is green here
The next step will be to create connector modules,
Please feel free to comment and reviw.

Thanks

@flotho flotho mentioned this pull request Jan 9, 2023
Merged
1 task
@flotho flotho changed the title WIP[16.0][MIG]connector dns [16.0][MIG]connector dns Jan 22, 2023
@bosd
Copy link

bosd commented Nov 3, 2023

Can you fix pre-commit?

@flotho
Copy link
Member Author

flotho commented Nov 4, 2023

Can you fix pre-commit?

with pleasure,
Done !

@flotho
Copy link
Member Author

flotho commented Nov 4, 2023

hum @bosd , did I miss something on the pylint issue?
Not sur I can do something here!

@bosd
Copy link

bosd commented Nov 16, 2023

hum @bosd , did I miss something on the pylint issue?
Not sur I can do something here!

Hmm, maybe this repo needs an update with copier update

@flotho flotho force-pushed the 16.0-mig-connector_dns branch 2 times, most recently from 10397af to b05c167 Compare May 25, 2024 20:50
@flotho flotho changed the title [16.0][MIG]connector dns [16.0][ADD]Base dns infrastructure May 25, 2024
@flotho
Copy link
Member Author

flotho commented May 25, 2024

hum @bosd , did I miss something on the pylint issue?
Not sur I can do something here!

Hmm, maybe this repo needs an update with copier update

Thanks for the proposal, sadly the command copier update failed. Do you have any tips/doc/recommandation on how to use copier in OCA projects ?

@flotho
Copy link
Member Author

flotho commented May 25, 2024

not sure to understand what's wrong in this pre commit

@bosd
Copy link

bosd commented May 25, 2024

Ooh I think the copier update' of the repo has already been done recently.

Try rebasing your branch. That should fix it.

bosd
bosd suggested changes May 25, 2024
View reviewed changes
Copy link

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very quick code review. The suggested changes should make gh actions happy. 💚

base_dns_infrastructure/__manifest__.py
"category": "Services",
"application": True,
"external_dependencies": {
"python": ["validator_collection"],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"python": ["validator_collection"],
"python": ["validator-collection"],

requirements.txt
@@ -0,0 +1,2 @@
# generated from manifests external_dependencies
validator_collection
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
validator_collection
validator-collection

.pylintrc-mandatory
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change any of the . dotfiles?
Maybe better to exclude the changes, for the CI.

base_dns_infrastructure/static/description/icon.png
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can replace (overwrite) this file, with the new icon you created.

base_dns_infrastructure/data/dns_record_type.xml
<?xml version="1.0" encoding="utf-8" ?>
<odoo noupdate="1">
<record model="ir.module.category" id="module_category_infrastructure_dns">
<field name="name">Infrastructure et DNS</field>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="name">Infrastructure et DNS</field>
<field name="name">Infrastructure and DNS</field>

@flotho flotho mentioned this pull request May 26, 2024
Merged
@flotho
Copy link
Member Author

flotho commented May 26, 2024

closed in favor of #20

@flotho flotho closed this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosd bosd bosd requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flotho @sbidoul @bosd