Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 mig intrastat base #37

Merged
merged 75 commits into from
Aug 8, 2018
Merged

Conversation

rvalyi
Copy link
Member

@rvalyi rvalyi commented Jul 28, 2018

supersedes #28

@astirpe I took all your remarks from #28 into account, is it ok for merging for you now?
cc @BT-kaberer @feketemihai @alexis-via

Alexis de Lattre and others added 30 commits March 9, 2018 16:22
…tat_product/service object is stored in database, we don't need the legal_intrastat state on invoices any more, because we will be able to create entry lines for DEB for a repair of equipment under warranty without using a legal_intrastat. Report_intrastat_type is now only required for DEB -> object moved to module l10n_fr_intrastat_product. For DEB, the button "regenerate lines" only regenerate DEB lines related to invoices.

Renamed intrastat base module, because it doesn't have France-specific parameters any more.

Add demo data.
…port_intrastat_type table, restarting OpenERP and re-creating intrastat types. Moved intrastat departments from stock.warehouse to stock.location. Dropped SQL queries ; replaced by traditionnal python code logic. No more need to have one rate per day for invoices with foreign currency. Add total fiscal value for DEB More code factorization. Prepare translation work.
… Moved configuration about taxes from company form to tax form Some modifications to ease v5 -> v6 migration : - object report_intrastat_code now belong to group account manager - button functions now return True Tried to implement the following feature : open attachement form when the XML file as been generated : works on v6, but make client crash en v5 -> code has been commented DEB lines with procedure code = 25 are now deducted from the fiscal total. Round invoice total.
… l10n_fr_intrastat_product to intrastat_base, because it should also be used in the module l10n_fr_intrastat_service. Take this field into account in the generation of DEB lines (module l10n_fr_intrastat_service).
…to the EU but invoice outside of the EU, your customer needs to have a fiscal representative inside the EU, which will be used for the DEB . depend on base_vat instead of account.
…hysical person in the EU with VAT, the move is not declared in DEB, so it must not block with a "raise" if the partner doesn't have a VAT number.
…as is_accessory_cost services but no regular product -> DES If the invoice has is_accessory_cost services and regular product -> added to the cost of products in DEB

Now allows "pricelist for statistical value" which is not in EUR (the currency conversion will be made from the pricelist currency to EUR)

Usability improvements :
- Order for DEB and DES tree view : "the more recent at the top"
- distinction between "Information to declare" and "Additionnal information" in intrastat lines
…ive" field in order to avoid the "compression" of the VAT field that made it too small.
…ncluding your own country - When generating lines for Intrastat Product/Service, all invoices for which country == Company's country are excluded
…ligation_level on res.company Add group group_detailed_intrastat_product, so that companies that only use obligation = simplified don't see all the additionnal fields. Remove transaction code corresponding to repairs in intrastat types Better on_change on intrastat types (code is mutualised with field.function) Update syntax : demo_xml/update_xml/init_xml -> data/demo
…astat_service (hope that Akretion France won't forget it's own declarations now !!!) On report.intrastat.product and report.intrastat.service : add copy() fonctions, tracking of important fields, a year_month function field and enhance views. Remove date_done field (the tracking in the chatter does the job). Remove class instanciation in the code.
…p "Detailed intrastat product". Remove dead code and fields that was used when we had to put DEB lines for repair operations (a thing of the past !). Update coding style. Reduce the number of flake8 warnings.
…nload the attachement via the drop down list on the form view, the name of the file will be the name of the attachement and not datas_fname ; so we need to have name = datas_fname.
alexis-via and others added 20 commits March 9, 2018 16:22
Add default values for intrastat transaction on company
Code cleanup
Take into account the taxes for B2C
Small code cleanup
Re-organise view of intrastat.product.declaration
Set more fields as invisible (localisation should put them visible if they need it)
Fix handling of suppl. units when hs_code is empty on invoice line (but set on product)
Small usability enhancements
Add transport mode in computation tree view
Rename variables
Set 2 other modules to uninstallable
Update README.rst: switch to new intrastat project
…g > Report > PDF Reports (because intrastat reports are not in PDF !)
intrastat_base: Move company view params to account config page
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvalyi rvalyi mentioned this pull request Jul 30, 2018
@astirpe
Copy link
Member

astirpe commented Jul 31, 2018

Not blocking request: could you add the readme files? See https://github.com/OCA/maintainer-tools/tree/master/template/module/readme

@luc-demeyer luc-demeyer self-requested a review August 8, 2018 13:05
@luc-demeyer
Copy link
Contributor

code review + tests ok.
Unit tests have been added which is great (we should backport these to the 10.0 version).
Small remark: oca icon not available.

@pedrobaeza pedrobaeza added this to the 11.0 milestone Aug 8, 2018
@pedrobaeza pedrobaeza merged commit 3d53859 into OCA:11.0 Aug 8, 2018
@pedrobaeza pedrobaeza mentioned this pull request Aug 8, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants