Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][IMP] iot #42

Merged
merged 6 commits into from
Dec 17, 2021
Merged

[13.0][IMP] iot #42

merged 6 commits into from
Dec 17, 2021

Conversation

etobella
Copy link
Member

THis PR include several improvements/fixes:

  • Fix iot_template_oca description
  • Adds an image field on device and template
  • Does not allow to execute and input/output from an archived device
  • Sets admin user as IoT Manager

@lubusax

lubusax
lubusax approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@lubusax lubusax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the tree view of "iot.device", it should be "IP" instead of "Ip"

Is there a possibility to upload the device image from the template?

@pedrobaeza
Copy link
Member

Instead of an image, I was thinking in a selection field with a fa icon (example fa-desktop), and in the kanban view, put such class. Do you get me?

olgamarcocb
olgamarcocb approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@olgamarcocb olgamarcocb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@etobella etobella mentioned this pull request Dec 17, 2021
Closed
@olgamarcocb olgamarcocb force-pushed the 13.0-imp-templates branch 2 times, most recently from 60d25b3 to 7159f67 Compare December 17, 2021 12:58
@etobella
Copy link
Member Author

@pedrobaeza Comments attended
image

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-42-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 33c44ff into OCA:13.0 Dec 17, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 89df717. Thanks a lot for contributing to OCA. ❤️

etobella pushed a commit to tegin/iot that referenced this pull request Feb 2, 2022
@OCA-git-bot
Merge PR OCA#42 into 13.0
7dba6cc 
Signed-off-by pedrobaeza
etobella pushed a commit to tegin/iot that referenced this pull request Feb 2, 2022
@OCA-git-bot
Merge PR OCA#42 into 13.0
fd1044e 
Signed-off-by pedrobaeza
etobella pushed a commit to tegin/iot that referenced this pull request Feb 2, 2022
@OCA-git-bot
Merge PR OCA#42 into 13.0
36180e2 
Signed-off-by pedrobaeza
etobella pushed a commit to tegin/iot that referenced this pull request Feb 2, 2022
@OCA-git-bot
Merge PR OCA#42 into 13.0
7bb10e2 
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olgamarcocb olgamarcocb olgamarcocb approved these changes

@lubusax lubusax lubusax approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@etobella @pedrobaeza @OCA-git-bot @lubusax @olgamarcocb