Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] iot_oca: Migration to 14.0 #44

Merged
merged 14 commits into from
Dec 18, 2021
Merged

Conversation

etobella
Copy link
Member

@etobella etobella commented Dec 17, 2021

renamed iot.system to iot.communication.system.

Migration scripts done, and tested with a small demo database.

@etobella etobella added this to the 14.0 milestone Dec 17, 2021
@etobella
Copy link
Member Author

/ocabot migration iot_oca

@etobella etobella mentioned this pull request Dec 17, 2021
6 tasks
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to squash administrative commits with the corresponding real commit that generates them

Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

etobella and others added 9 commits December 18, 2021 07:46
Adds active field in device, input
Adds device_identification and passphrase in device
Adds address field in input
Adds new controller that can take multi event and/or multi input data
Updates tests
[FIX] Don't remove existing users from security group
Updating the module removed existing users from Manager group.
This changes behaviour so that users that are already in this group
are not removed.
Added some comments for a future myself
@etobella
Copy link
Member Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-44-by-etobella-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 18, 2021
Signed-off-by etobella
@OCA-git-bot
Copy link
Contributor

@etobella your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-44-by-etobella-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@etobella
Copy link
Member Author

Let's try again
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-44-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6c36449 into OCA:14.0 Dec 18, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1fe572f. Thanks a lot for contributing to OCA. ❤️

@olgamarcocb olgamarcocb deleted the 14.0-mig-iot_oca branch December 21, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants