[MIG] document_url: Migration to 15.0 #353
Conversation
[MIG] document_url * bump version to 9.0.1.0.0 and make it installable * Update JS structure * Add css in order to be compliant with odoo style * Add a README.rst and OCA conventions * Improve selector * add fr.po for fr translation * open link with target='_blank'
Without this patch, when you hover on the menu item, its background color does not change, and its cursor is a text one. With this patch, the menu item styling matches those available in all surrounding menus.
Replace char © by word Copyright Change format in usage description
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-12.0/knowledge-12.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_url/
Currently translated at 100.0% (14 of 14 strings) Translation: knowledge-12.0/knowledge-12.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_url/hr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-13.0/knowledge-13.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-document_url/
matiasperalta1
force-pushed
the
15.0-t-25911-mnp
branch
3 times, most recently
from
a6c6813
to
9044c8f
Compare
matiasperalta1
force-pushed
the
15.0-t-25911-mnp
branch
from
9044c8f
to
a9abd97
Compare
|
@victoralmau Hi Victor. I contact you to ask you a question for this module. I'm migrating this module to v15 and I have seen that some changes were made by you in the migration to v14. I am trying to use the mimetype "application/link" but it is not working for me because I think it is invalid. How have you made it work? |
|
Hi, the approach is correct. I think the first thing to do is to add all the changes from v14 to the commit history. These changes are explained in the v14 migration PR: #306 |
[MIG] document_url: Migration to 14.0
Define the add attachment and add URL buttons on the same line. Allow downloading of url type attachments by clicking on the icon or the name. Define the name of the url type attachments as links (allows to open it in a new tab). Hide the download button for url attachments. Force to set mimetype to "application/link" for url attachments. Displays a link icon for url attachments. TT30263
matiasperalta1
force-pushed
the
15.0-t-25911-mnp
branch
from
a9abd97
to
411a6b6
Compare
|
/ocabot migration document_url |
|
The migration issue (#308) has been updated to reference the current pull request. |
|
Everything is working now except having "Add attachments" and "Add URL" in 2 lines instead of one. Can you please check it? |
@legalsylvain it seems the new check is not correct, as the referenced PR is closed |
There was a problem hiding this comment.
Hi, thanks for the work.
- Do not delete
url.jsfile, make the necessary changes to reduce diff in commit - Squash administrative commits
Except for the comment in #353 (comment), everything would be correct.
matiasperalta1
force-pushed
the
15.0-t-25911-mnp
branch
from
411a6b6
to
c9ef6bd
Compare
|
Pre-commit is failing. |
matiasperalta1
force-pushed
the
15.0-t-25911-mnp
branch
from
c9ef6bd
to
2b4aca3
Compare
|
@pedrobaeza Pre-commit Fixed |
|
Thanks for the contribution /ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 27f447a. Thanks a lot for contributing to OCA. ❤️ |
No description provided.