Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] companyweb_payment_info #212

Merged
merged 20 commits into from
Mar 13, 2024

Conversation

mathisjacoby
Copy link
Contributor

Migration of module companyweb_payment_info based on 16.0

  • Allow requests to companyweb API from tests
  • Correct bug about period year and period month in start transaction call : Sending now the period up until which the data is up to date

@mathisjacoby mathisjacoby force-pushed the 17.0-mig-companyweb_payment_info branch from 8c630b0 to 6152da8 Compare December 6, 2023 16:25
@mathisjacoby mathisjacoby marked this pull request as draft December 6, 2023 16:26
@xavier-bouquiaux xavier-bouquiaux force-pushed the 17.0-mig-companyweb_payment_info branch 2 times, most recently from 92dba95 to 9a32a7b Compare March 11, 2024 15:10
@mathisjacoby mathisjacoby marked this pull request as ready for review March 12, 2024 09:39
)
)

def _cweb_start_transaction(self, client, email, perdiod_to_send):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def _cweb_start_transaction(self, client, email, perdiod_to_send):
def _cweb_start_transaction(self, client, email, period_to_send):

Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little typo, otherwise looks good.

@sbidoul
Copy link
Member

sbidoul commented Mar 13, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-212-by-sbidoul-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4a6fad2 into OCA:17.0 Mar 13, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9b61628. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul deleted the 17.0-mig-companyweb_payment_info branch May 1, 2024 17:29
@sbidoul
Copy link
Member

sbidoul commented Jul 8, 2024

/ocabot migration companyweb_payment_info

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 8, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 8, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants