Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] Valor dos produtos na NF-e #3109

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

antoniospneto
Copy link
Sponsor Contributor

Após a PR #3016, ocorreu uma regressão na emissão da NF-e. Ao tentar emitir a nota, a SEFAZ retornava a seguinte rejeição:

image

A causa do problema era o campo nfe40_vProd, que estava recebendo um valor incorreto. Esse campo é um related ao campo price_gross, cuja lógica foi alterada na #3016. O campo price_gross deve refletir o valor total dos produtos (quantidade x preço unitário). Esta PR reverte a lógica para garantir que price_gross reflita corretamente esse valor.

Para evitar futuros equívocos, melhorei a descrição do campo price_gross e adicionei casos de testes.

Em rascunho pois ainda estou aprimorando os testes unitários,

@OCA-git-bot
Copy link
Contributor

Hi @renatonlima, @rvalyi, @felipemotter, @mbcosta,
some modules you are maintaining are being modified, check this out!

@mileo
Copy link
Member

mileo commented Jun 19, 2024

No PR #3135 altero a origem do total dos produtos para condizer com o total dos produtos da NFE:

image

@antoniospneto antoniospneto force-pushed the 14.0-fix-fiscal-product-value branch 3 times, most recently from 762836c to c5f28e2 Compare July 13, 2024 14:37
@antoniospneto antoniospneto force-pushed the 14.0-fix-fiscal-product-value branch 2 times, most recently from 7acfa4b to d067a03 Compare July 17, 2024 22:52
@antoniospneto
Copy link
Sponsor Contributor Author

antoniospneto commented Jul 17, 2024

PR pronta para revisão.

Aproveitei para incrementar os testes e garantir uma cobertura mais abrangente.

@rvalyi, no commit a4f82ef, encapsulei a configuração dos dados da empresa normal dentro da classe de testes common. Isso permite reaproveitar os mesmos dados no teste que criei no módulo l10n_br_account_nfe. Tudo bem para você?

@antoniospneto antoniospneto marked this pull request as ready for review July 17, 2024 23:22
@antoniospneto
Copy link
Sponsor Contributor Author

Dei um rebase pois tinha esquecido um trecho de código morto.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parabéns e obrigado novamente.

@rvalyi
Copy link
Member

rvalyi commented Jul 18, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-3109-by-rvalyi-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9d8c6dc into OCA:14.0 Jul 18, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d2b754b. Thanks a lot for contributing to OCA. ❤️

@marcelsavegnago
Copy link
Sponsor Member

marcelsavegnago commented Jul 19, 2024

@antoniospneto vlwwww

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants