Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][l10n_br_fiscal][FIX] l10n_br_fiscal: amount gross / product values #3202

Merged
merged 2 commits into from
Jul 29, 2024
Merged

[16.0][l10n_br_fiscal][FIX] l10n_br_fiscal: amount gross / product values #3202

merged 2 commits into from
Jul 29, 2024

Conversation

rvalyi
Copy link
Member

@rvalyi rvalyi commented Jul 22, 2024 •
edited
Loading

port #3109

nota: nao passou os testes na 15.0 #3194 (comment)

@rvalyi rvalyi marked this pull request as draft July 22, 2024 03:35
@OCA-git-bot
Copy link
Contributor

Hi @renatonlima,
some modules you are maintaining are being modified, check this out!

@rvalyi rvalyi force-pushed the oca-port-from-14.0-to-16.0-pr-3109 branch from 63b4726 to 73f63e9 Compare July 28, 2024 13:14
@rvalyi
Copy link
Member Author

rvalyi commented Jul 28, 2024

@antoniospneto deu o mesmo erro do que no port para a v15, se puder ver...

2024-07-28 13:17:37,519 361 ERROR odoo odoo.addons.l10n_br_fiscal.tests.test_fiscal_document_generic: FAIL: TestFiscalDocumentGeneric.test_nfe_same_state
Traceback (most recent call last):
  File "/__w/l10n-brazil/l10n-brazil/l10n_br_fiscal/tests/test_fiscal_document_generic.py", line 181, in test_nfe_same_state
    self.assertEqual(self.nfe_same_state.amount_price_gross, 3965)
AssertionError: 430.5 != 3965

@antoniospneto
Copy link
Contributor

@rvalyi se puder incluir o cherry-pick do commit 8ebf397
Conforme correção feita aqui: #3244

@rvalyi rvalyi mentioned this pull request Jul 29, 2024
Merged
@rvalyi rvalyi force-pushed the oca-port-from-14.0-to-16.0-pr-3109 branch from e3171ea to 0365801 Compare July 29, 2024 12:01
@rvalyi rvalyi marked this pull request as ready for review July 29, 2024 12:37
@rvalyi rvalyi mentioned this pull request Jul 29, 2024
Merged
@renatonlima
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3202-by-renatonlima-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit a01fa9d into OCA:16.0 Jul 29, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6194d2d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@antoniospneto antoniospneto antoniospneto approved these changes

@renatonlima renatonlima renatonlima approved these changes

Assignees
No one assigned
Labels
16.0 approved backport merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rvalyi @OCA-git-bot @antoniospneto @renatonlima @marcelsavegnago