Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] l10n_it_pos_fatturapa #1542

Merged
merged 3 commits into from
Jan 2, 2020
Merged

[12.0] l10n_it_pos_fatturapa #1542

merged 3 commits into from
Jan 2, 2020

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Nov 25, 2019

From #1541

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@OCA-git-bot
Copy link
Contributor

Hi @robyf70,
some modules you are maintaining are being modified, check this out!

@GSLabIt
Copy link
Contributor

GSLabIt commented Nov 28, 2019

@eLBati, già che ci siamo.. magari si può aggiungere un campo per il codice lotteria scontrini..

@robyf70
Copy link
Contributor

robyf70 commented Nov 28, 2019

@GSLabIt Possiamo anche farlo però a quanto pare https://quifinanza.it/fisco-tasse/lotteria-degli-scontrini-tutto-rinviato-si-parte-il-1-luglio-2020/330357/ e magari lo mettiamo come semplice campo Char

@GSLabIt
Copy link
Contributor

GSLabIt commented Nov 28, 2019

aspettiamo il 30 giugno 😬

@eLBati
Copy link
Member Author

eLBati commented Nov 28, 2019

#1541 (comment)

mrcast
mrcast reviewed Nov 30, 2019
View reviewed changes
Copy link
Contributor

@mrcast mrcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eLBati : mi sembra che manchi il controllo di obbligatorietà di Piva o CF, mentre funziona correttamente quello di completezza indirizzo

@robyf70
Copy link
Contributor

robyf70 commented Dec 1, 2019

@mrcast Il modulo dovrà essere rebasato sulla #1541 perchè ho apportato alcune modifiche. Riguardo al check su PIVA e/o CF, questo viene fatto server side.

@eLBati
Copy link
Member Author

eLBati commented Dec 2, 2019

@mrcast sul runbot di questa PR ottengo

image

Che passi fai per produrre il problema?

mrcast
mrcast approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@mrcast mrcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test funzionale ok, grazie

primes2h
primes2h requested changes Dec 2, 2019
View reviewed changes
l10n_it_pos_fatturapa/i18n/it.po Outdated Show resolved Hide resolved
l10n_it_pos_fatturapa/__manifest__.py Outdated Show resolved Hide resolved
@eLBati eLBati mentioned this pull request Dec 2, 2019
Merged
@eLBati
Copy link
Member Author

eLBati commented Dec 29, 2019

#1541 merged
@mrcast @GSLabIt @primes2h @robyf70 procedo anche con questa?

robyf70
robyf70 suggested changes Dec 29, 2019
View reviewed changes
Copy link
Contributor

@robyf70 robyf70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per il resto LGTM

l10n_it_pos_fatturapa/__init__.py Outdated Show resolved Hide resolved
l10n_it_pos_fatturapa/models/__init__.py Outdated Show resolved Hide resolved
l10n_it_pos_fatturapa/models/res_partner.py Outdated Show resolved Hide resolved
@primes2h
Copy link
Contributor

Peek 29-12-2019 10-57

@primes2h
Copy link
Contributor

primes2h commented Dec 29, 2019 •
edited
Loading

@eLBati non è possibile inserire i dati per la fatturazione elettronica in un solo passaggio, i campi non vengono attivati/disattivati spuntando la casella.

primes2h
primes2h reviewed Dec 29, 2019
View reviewed changes
Copy link
Contributor

@primes2h primes2h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il resto è ok.

l10n_it_pos_fatturapa/i18n/it.po Outdated Show resolved Hide resolved
@eLBati
Copy link
Member Author

eLBati commented Dec 29, 2019

@robyf70 @primes2h grazie, fatto.

@eLBati
ADD setup
6e750fa 
and improve IPA label
robyf70
robyf70 approved these changes Dec 29, 2019
View reviewed changes
Copy link
Contributor

@robyf70 robyf70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@primes2h
Copy link
Contributor

@eLBati hai per caso visto questo #1542 (comment) relativo a #1542 (comment) ?

@eLBati
Copy link
Member Author

eLBati commented Dec 30, 2019

@primes2h sìsì, corretto

@primes2h
Copy link
Contributor

@primes2h sìsì, corretto

👍
Ottimo, grazie!

@eLBati
Copy link
Member Author

eLBati commented Jan 2, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-1542-by-eLBati-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 2, 2020
@OCA-git-bot
Merge PR #1542 into 12.0
ddfc1b1 
Signed-off-by eLBati
@OCA-git-bot OCA-git-bot merged commit 6e750fa into OCA:12.0 Jan 2, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 718c6ac. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primes2h primes2h primes2h approved these changes

@robyf70 robyf70 robyf70 approved these changes

@mrcast mrcast mrcast approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eLBati @OCA-git-bot @GSLabIt @robyf70 @primes2h @mrcast