Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] Port l10n_it_account_stamp_sale #1574

Merged
merged 6 commits into from
Jan 24, 2020
Merged

[12.0] Port l10n_it_account_stamp_sale #1574

merged 6 commits into from
Jan 24, 2020

Conversation

sergiocorato
Copy link
Contributor

[IMP] port l10n_it_account_stamp_sale to 12.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@OCA-git-bot
Copy link
Contributor

Hi @tafaRU,
some modules you are maintaining are being modified, check this out!

@sergiocorato sergiocorato changed the title index on upstream/12.0: 902e85312 [ADD] setup.py [12.0] Port l10n_it_account_stamp_sale Jan 4, 2020
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 4, 2020
Closed
35 tasks
@eLBati
Copy link
Member

eLBati commented Jan 4, 2020

@sergiocorato dovresti mantenere la storia seguendo
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-12.0#howto
(usando 10.0 invece di 11.0 visto che sulla 11 il modulo non c'è)

@sergiocorato sergiocorato force-pushed the 12.0-mig-l10n_it_account_stamp_sale branch from 54ba896 to 80e3e1a Compare January 4, 2020 21:25
@sergiocorato
Copy link
Contributor Author

@eLBati grazie, dovrei aver corretto

tafaRU
tafaRU requested changes Jan 7, 2020
View reviewed changes
Copy link
Member

@tafaRU tafaRU left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie per la migrazione!

Oltre alle piccole richieste di modifica, ti chiedo di modificare il commit message in [MIG] l10n_it_account_stamp_sale: Migration to 12.0 come da linee guida.

l10n_it_account_stamp_sale/__manifest__.py Outdated Show resolved Hide resolved
l10n_it_account_stamp_sale/models/sale_order.py Outdated Show resolved Hide resolved
@sergiocorato sergiocorato force-pushed the 12.0-mig-l10n_it_account_stamp_sale branch 2 times, most recently from aeb37b3 to 4bd77e4 Compare January 8, 2020 11:07
tafaRU
tafaRU reviewed Jan 9, 2020
View reviewed changes
l10n_it_account_stamp_sale/__manifest__.py Outdated
# Copyright 2019 Alex Comba - Agile Business Group
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

{
'name': 'Italian Localization - Imposta di bollo - vendite',
'summary': "Modulo ponte tra imposta di bollo e vendite",
'version': '10.0.1.0.1',
'version': '12.0.1.0.1',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trattandosi di un nuovo modulo la versione corretta è 12.0.1.0.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fatto

@sergiocorato sergiocorato force-pushed the 12.0-mig-l10n_it_account_stamp_sale branch from 4bd77e4 to c37e30e Compare January 13, 2020 15:35
primes2h
primes2h requested changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@primes2h primes2h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisione documentale, giusto due piccole correzioni per uniformarsi alle linee guida.

l10n_it_account_stamp_sale/__manifest__.py Outdated
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

{
'name': 'Italian Localization - Imposta di bollo - vendite',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Italian Localization/ITA
s/vendite/Vendite

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fatt!

@sergiocorato sergiocorato force-pushed the 12.0-mig-l10n_it_account_stamp_sale branch from c37e30e to f0d4ecf Compare January 14, 2020 15:36
@sergiocorato sergiocorato force-pushed the 12.0-mig-l10n_it_account_stamp_sale branch from f0d4ecf to fdb932f Compare January 14, 2020 15:38
@sergiocorato
Copy link
Contributor Author

se non c'è altro procediamo al merge?

primes2h
primes2h approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@primes2h primes2h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tafaRU
Copy link
Member

tafaRU commented Jan 24, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-1574-by-tafaRU-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 24, 2020
@OCA-git-bot
Merge PR #1574 into 12.0
b14d708 
Signed-off-by tafaRU
@OCA-git-bot OCA-git-bot merged commit fdb932f into OCA:12.0 Jan 24, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 92773df. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tafaRU tafaRU tafaRU approved these changes

@primes2h primes2h primes2h approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sergiocorato @OCA-git-bot @eLBati @tafaRU @primes2h @francesco-ooops @oca-travis