Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] FIX l10n_it_fatturapa_in importing refund XML with negative total #1587

Merged
merged 1 commit into from
Jan 16, 2020
Merged

[12.0] FIX l10n_it_fatturapa_in importing refund XML with negative total #1587

merged 1 commit into from
Jan 16, 2020

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Jan 9, 2020

and ADD test for refund with positive total

See added tests

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

mrcast
mrcast approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@mrcast mrcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test ok!
Tks

@eLBati
ADD test for refund with positive total
66492dc 
FIX importing refund XML with negative lines
sergiocorato
sergiocorato approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@sergiocorato sergiocorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@eLBati
Copy link
Member Author

eLBati commented Jan 15, 2020

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-1587-by-eLBati-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 15, 2020
@OCA-git-bot
Merge PR #1587 into 12.0
3ca58e4 
Signed-off-by eLBati
@OCA-git-bot
Copy link
Contributor

@eLBati your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-1587-by-eLBati-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@eLBati
Copy link
Member Author

eLBati commented Jan 16, 2020

Rif #1588

@eLBati
Copy link
Member Author

eLBati commented Jan 16, 2020

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-1587-by-eLBati-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 16, 2020
@OCA-git-bot
Merge PR #1587 into 12.0
a694187 
Signed-off-by eLBati
@OCA-git-bot OCA-git-bot merged commit 66492dc into OCA:12.0 Jan 16, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 643f04e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tafaRU tafaRU tafaRU approved these changes

@sergiocorato sergiocorato sergiocorato approved these changes

@mrcast mrcast mrcast approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eLBati @OCA-git-bot @tafaRU @sergiocorato @mrcast