Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] l10n_it_vat_registries #3564

Merged
merged 32 commits into from
Sep 14, 2023

Conversation

SirAionTech
Copy link
Contributor

Sostituisce #3080.

@SirAionTech SirAionTech marked this pull request as ready for review September 7, 2023 14:06
@SirAionTech SirAionTech marked this pull request as draft September 7, 2023 14:08
@SirAionTech SirAionTech marked this pull request as ready for review September 7, 2023 14:18
@tafaRU
Copy link
Member

tafaRU commented Sep 7, 2023

Le review funzionali rimangono valide dalla #3080

@tafaRU
Copy link
Member

tafaRU commented Sep 7, 2023

/ocabot migration l10n_it_vat_registries

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 7, 2023
@OCA-git-bot
Copy link
Contributor

The migration issue (#2967) has not been updated to reference the current pull request because a previous pull request (#3080) is not closed.
Perhaps you should check that there is no duplicate work.
CC @Borruso

@tafaRU
Copy link
Member

tafaRU commented Sep 7, 2023

/ocabot migration l10n_it_vat_registries

@OCA-git-bot OCA-git-bot mentioned this pull request Sep 7, 2023
79 tasks
Copy link
Contributor

@MarcoCalcagni MarcoCalcagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test funzionali OK

Copy link
Contributor

@scigghia scigghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@marcelofrare marcelofrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@andreampiovesana
Copy link
Contributor

image

@andreampiovesana
Copy link
Contributor

@tafaRU merge?

@tafaRU
Copy link
Member

tafaRU commented Sep 8, 2023

Provando a stamapare una liquidazione iva sul runboat ottengo il pdf allegato
Print Vat Period End Statement.pdf

image

Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SirAionTech
Copy link
Contributor Author

#3564 (comment)

🤔 dev'essere per 4473385, quando riesco ci guardo, oppure ci può guardare @Borruso che ha fatto la modifica?

@tafaRU
Copy link
Member

tafaRU commented Sep 8, 2023

🤔 dev'essere per 4473385

eh sì per quello ho fatto quel test 😉

@Borruso
Copy link
Contributor

Borruso commented Sep 8, 2023

🤔 dev'essere per 4473385

eh sì per quello ho fatto quel test 😉

per il problema della visualizzazione togli le modifiche collegate al header

eLBati and others added 7 commits September 8, 2023 15:19
Currently translated at 75.0% (45 of 60 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/
Currently translated at 95.0% (57 of 60 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/

Translated using Weblate (Italian)

Currently translated at 96.7% (58 of 60 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/

Translated using Weblate (Italian)

Currently translated at 96.7% (58 of 60 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/
@SirAionTech SirAionTech force-pushed the 16.0-mig-l10n_it_vat_registries branch from cd26d44 to acfa01c Compare September 8, 2023 14:14
@SirAionTech SirAionTech marked this pull request as ready for review September 8, 2023 14:14
@SirAionTech
Copy link
Contributor Author

Provando a stamapare una liquidazione iva sul runboat ottengo il pdf allegato Print Vat Period End Statement.pdf

image

Ho provato entrambe le stampe (allegate) in runboat e mi sembrano a posto, puoi verificare?
Print Vat Period End Statement.pdf
Invoices VAT Registry.pdf

Copy link

@marcelofrare marcelofrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM le stampe dopo le modifiche di @SirAionTech
Grazie

image

@TheMule71
Copy link
Contributor

visto che acfa01c disfa molto di c12e250, io li squasherei, tanto gli autori sono già giusti, e vediamo cosa rimane

@SirAionTech SirAionTech marked this pull request as draft September 11, 2023 08:15
@SirAionTech SirAionTech marked this pull request as ready for review September 11, 2023 08:19
@SirAionTech
Copy link
Contributor Author

SirAionTech commented Sep 11, 2023

visto che acfa01c disfa molto di c12e250, io li squasherei, tanto gli autori sono già giusti, e vediamo cosa rimane

Ho ripulito un po' i commit, visto che ho dovuto ripartire da 0 per capire cosa stesse andando storto in account_vat_period_end_statement e l10n_it_account mi sono preso l'authorship di quel commit.
Ho anche incluso il resto delle modifiche (c'era qualcosa anche in c12e250) nel commit di migrazione quindi mi sono messo come co-autore.
@Borruso fammi sapere se per te è ok

@Borruso
Copy link
Contributor

Borruso commented Sep 12, 2023

visto che acfa01c disfa molto di c12e250, io li squasherei, tanto gli autori sono già giusti, e vediamo cosa rimane

Ho ripulito un po' i commit, visto che ho dovuto ripartire da 0 per capire cosa stesse andando storto in account_vat_period_end_statement e l10n_it_account mi sono preso l'authorship di quel commit. Ho anche incluso il resto delle modifiche (c'era qualcosa anche in c12e250) nel commit di migrazione quindi mi sono messo come co-autore. @Borruso fammi sapere se per te è ok

per me ok

@andreampiovesana
Copy link
Contributor

good news?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tafaRU
Copy link
Member

tafaRU commented Sep 14, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3564-by-tafaRU-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f6dde34 into OCA:16.0 Sep 14, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 602dc87. Thanks a lot for contributing to OCA. ❤️

@@ -1,5 +1,5 @@
table {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SirAionTech
Ciao, questo CSS interferisce con le classi standard di Odoo tipo table-bordered, che, dopo aver installato l10n_it_account perdono i bordi.

Ti ricordi il perché di questo !important e non sarebbe meglio associarlo ad una classe apposita invece "colpire" tutte le table indiscriminatamente?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 ricordo che avevo tolto un po' di cose da 9694c33, probabilmente questo l'ho lasciato così perché è un modo per mantenere lo stesso comportamento che c'era in 14.0.
Concordo che sarebbe meglio usare una classe apposta, anche in 14.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheMule71 c'è già una issue o puoi aprirla?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@francesco-ooops
Eh, devo costruire un es. apposta...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.