Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [ADD] l10n_it_delivery_note_inter_company #3659

Merged
merged 2 commits into from
Nov 23, 2023
Merged

[14.0] [ADD] l10n_it_delivery_note_inter_company #3659

merged 2 commits into from
Nov 23, 2023

Conversation

renda-dev
Copy link
Contributor

@renda-dev renda-dev commented Oct 10, 2023 •
edited
Loading

This module depends on OCA/multi-company#507 and OCA/multi-company#526

@renda-dev renda-dev force-pushed the 14.0-add-l10n_it_delivery_note_inter_company branch 4 times, most recently from c683848 to 94c8e5b Compare October 12, 2023 16:04
@aleuffre aleuffre force-pushed the 14.0-add-l10n_it_delivery_note_inter_company branch from 94c8e5b to 1d128a3 Compare October 13, 2023 07:53
@renda-dev renda-dev force-pushed the 14.0-add-l10n_it_delivery_note_inter_company branch from 1d128a3 to bb785c6 Compare October 17, 2023 10:26
@francesco-ooops
Copy link
Contributor

@OCA/local-italy-maintainers la PR OCA/multi-company#507 su cui si basa il modulo è stata mergiata ma non riusciamo a vederne gli effetti nella PR, qualche suggerimento su come procedere?

@tafaRU
Copy link
Member

tafaRU commented Oct 17, 2023

@francesco-ooops quello che noto di strano è che qui non sta installando l'ultima versione. Mi sfugge però al momento come mai.

@matteoopenf
Copy link
Contributor

@francesco-ooops quello che noto di strano è che qui non sta installando l'ultima versione. Mi sfugge però al momento come mai.

potrebbe essere un problema di cache di qualche tipo?

@tafaRU
Copy link
Member

tafaRU commented Oct 17, 2023 •
edited
Loading

@francesco-ooops le dipendenze vengono cercate Looking in indexes: https://wheelhouse.odoo-community.org/oca-simple-and-pypi (rif. https://github.com/OCA/l10n-italy/actions/runs/6545894955/job/17775273159#step:4:43)

e mi pare che venga recuperata sempre l'ultima versione realease mentre le pre-release non vengono considerate.

Esempio:

@SirAionTech
Copy link
Contributor

qualche suggerimento su come procedere?

Puoi provare a far generare una nuova versione per il modulo che ti interessa con una nuova PR dove incrementi solo la versione, ad esempio come fatto in OCA/server-tools@f6586c4.

@renda-dev renda-dev mentioned this pull request Oct 23, 2023
Merged
@renda-dev renda-dev force-pushed the 14.0-add-l10n_it_delivery_note_inter_company branch 4 times, most recently from 62ca4d1 to 936a8d2 Compare October 25, 2023 09:27
@renda-dev renda-dev mentioned this pull request Oct 27, 2023
Merged
@renda-dev renda-dev force-pushed the 14.0-add-l10n_it_delivery_note_inter_company branch from 936a8d2 to 7bed88a Compare October 27, 2023 12:32
@aleuffre aleuffre force-pushed the 14.0-add-l10n_it_delivery_note_inter_company branch from 7bed88a to fad5d36 Compare October 31, 2023 11:41
francesco-ooops
francesco-ooops approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

@renda-dev renda-dev force-pushed the 14.0-add-l10n_it_delivery_note_inter_company branch 2 times, most recently from f9db1ae to 3f9827e Compare November 9, 2023 15:58
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

Questa si può mergiare?

@francesco-ooops
Copy link
Contributor

@tafaRU merge?

@renda-dev renda-dev force-pushed the 14.0-add-l10n_it_delivery_note_inter_company branch from 3f9827e to 48043fc Compare November 23, 2023 11:51
@renda-dev renda-dev force-pushed the 14.0-add-l10n_it_delivery_note_inter_company branch 2 times, most recently from 906b865 to c649a27 Compare November 23, 2023 13:55
tafaRU
tafaRU requested changes Nov 23, 2023
View reviewed changes
Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit 🔴

@renda-dev renda-dev force-pushed the 14.0-add-l10n_it_delivery_note_inter_company branch from c649a27 to 3341c41 Compare November 23, 2023 15:27
@tafaRU
Copy link
Member

tafaRU commented Nov 23, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-3659-by-tafaRU-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 7d1f9fa into OCA:14.0 Nov 23, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 45345b3. Thanks a lot for contributing to OCA. ❤️

@renda-dev renda-dev deleted the 14.0-add-l10n_it_delivery_note_inter_company branch November 24, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francesco-ooops francesco-ooops francesco-ooops approved these changes

@GSLabIt GSLabIt GSLabIt approved these changes

@tafaRU tafaRU tafaRU approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 new module ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@renda-dev @francesco-ooops @tafaRU @matteoopenf @SirAionTech @OCA-git-bot @GSLabIt