Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Config Module for easier installation, configuration, loading datas... #7

Merged
merged 12 commits into from
Jan 20, 2016

Conversation

feketemihai
Copy link
Member

No description provided.

@feketemihai feketemihai added this to the 8.0 milestone Dec 7, 2015
@jgrandguillaume
Copy link
Member

Hi,

Difficult to say something on localization... Anyway, I'll try my best.

Code review done:

  • Everything alright
  • Good use of OCA template

My only comment on this is : Please add a .pot file then you'll get my 👍

Regards and thanks for contributing to OCA !

@feketemihai
Copy link
Member Author

Hi @jgrandguillaume, i will add the .pot file when finish with it...based on the repo from odoo romania i will add many other option when i will port the accounting modules.

Thanks for review.

…ation untill merge of them into OCA, add .pot file, translation.
@feketemihai
Copy link
Member Author

@OCA/core-maintainers Can i have some other reviews for the PR's, at least for this one since i have to add other options to the config...

@@ -0,0 +1,14 @@
<?xml version="1.0"?>
<openerp>
<data>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try not to mix tab and space in indentation of xml files

@feketemihai
Copy link
Member Author

@yvaucher The empty group is for format the view, just like in Accounting tab to use the center of the screen, not to expand untill rigth side.
The files are here for easier update of the data...for making them as of data files, will loose close to 5 minutes at every server update...so here we can choose the moment when to update them.

@feketemihai
Copy link
Member Author

Runbot fails due to psycopg2: OperationalError: FATAL: sorry, too many clients already, try to rebuild it but it's the same.

@yvaucher
Copy link
Member

Ok then 👍

yvaucher added a commit that referenced this pull request Jan 20, 2016
Add Config Module for easier installation, configuration, loading datas...
@yvaucher yvaucher merged commit 732f596 into OCA:8.0 Jan 20, 2016
@feketemihai feketemihai deleted the config branch May 9, 2016 03:52
feketemihai pushed a commit that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants