-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Config Module for easier installation, configuration, loading datas... #7
Conversation
Hi, Difficult to say something on localization... Anyway, I'll try my best. Code review done:
My only comment on this is : Please add a .pot file then you'll get my 👍 Regards and thanks for contributing to OCA ! |
Hi @jgrandguillaume, i will add the .pot file when finish with it...based on the repo from odoo romania i will add many other option when i will port the accounting modules. Thanks for review. |
…ation untill merge of them into OCA, add .pot file, translation.
@OCA/core-maintainers Can i have some other reviews for the PR's, at least for this one since i have to add other options to the config... |
@@ -0,0 +1,14 @@ | |||
<?xml version="1.0"?> | |||
<openerp> | |||
<data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try not to mix tab and space in indentation of xml files
@yvaucher The empty group is for format the view, just like in Accounting tab to use the center of the screen, not to expand untill rigth side. |
Runbot fails due to psycopg2: OperationalError: FATAL: sorry, too many clients already, try to rebuild it but it's the same. |
Ok then 👍 |
Add Config Module for easier installation, configuration, loading datas...
No description provided.