[15.0] [MIG] l10n_es_aeat_mod216 #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lculo por códigos de impuestos generalizado + tratamiento residentes 216 y cálculo, traducciones
…lugar de recordset + gestionar grupos de compañías
…ixes OCA#290 Cuando se tienen campos related, aunque el valor no se cambie, Odoo lanza una escritura en el objeto relacionado cada vez que se guarda el objeto principal. En el caso de la moneda asociada a la compañía, hace que aquellos usuarios que no tengan permiso para modificar la compañía (la mayoría), falle en la creación del modelo.
El anterior método utilizado, al tener una clase y un many2one genérico, no permitía poner los datos en múltiples modelos hijos, ya que se repetían los IDs, y cogía los datos de un modelo en otros. Con este nuevo sistema, se sigue utilizando una tabla, pero con doble índice: el modelo y el ID, parecido a un campo reference, pero gestionado por código propio en el método de cálculo. El 303 está adaptado a este nuevo sistema, y se incluye un script de migración que conserve los datos.
* Standard migration procedure
a nivel individualizado, sino agrupadas. Se corrije el filtro de asientos del mod 111 para que se tengan en cuenta los apuntes contables asociados a IRPF para tanto empresas que son residentes como para el caso en que no se ha informado la empresa en el apunte contable de la nómina. En caso del modelo 216, sí que parece más justificado tener que introducir el campo empresa.
This way, we don't initially see all the subconfigs for each model and we can concentrate on main export configurations. This is got through `active` field default behaviour. Archived config are still directly searchable through the subconfig selector in the configuration line. All models export configs have been adapted to this new approach.
Previous approach was not correct, as the used taxes don't apply to non resident. We use now l10n_es_irnr module for having proper taxes, map them in the model, and adapt the rest of the needed things.
* Float > Monetary and remove view definition * casilla_07 must be monetary (float), not integer
* Include chatter (mail.thread) * Include activities (mail.activity.mixin) * Track AEAT report state change * Include new admin user in AEAT group by default
…n tests This way, we can reuse it in other modules that don't inherit AEAT report like SII. We also clean a non needed reading of the tax description field. Tests were still using description method for populating data, so we switch to new system and perform needed changes in dependent tests. s
Shide
force-pushed
the
15.0-mig-l10n_es_aeat_mod216
branch
from
57292c1
to
91c82bf
Compare
pedrobaeza
reviewed
Oct 17, 2022
|
/ocabot migration l10n_es_aeat_mod216 |
Shide
force-pushed
the
15.0-mig-l10n_es_aeat_mod216
branch
from
91c82bf
to
4db1d77
Compare
|
Eduardo, pon porfa el mensaje de commit correcto (falta el nombre del módulo). Por lo demás, parece todo correcto. |
|
Hola, no puedo probar en runboat ningún modelo porque en runboat de l10n-spain no está el módulo Si alguien nos explica cómo nosotros añadimos el Eso sí, hay que actualizar en cada PR, en mi opinión y abriré una issue para debate creo que deberíamos poner ya, todos los impuestos en l10n_es y no añadirlos con cada modelo... Gracias |
|
La ruta para probarlo sería más bien:
|
Shide
force-pushed
the
15.0-mig-l10n_es_aeat_mod216
branch
from
4db1d77
to
c826531
Compare
Hecho, se me había colado la variable |
|
Gracias /ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 2cf77f8. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration from 13.0 to 15.0
MT-1426 @moduon