Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] l10n_es_account_statement_import_n43: Define transaction reference (same as v13) #3284

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[14.0][IMP] l10n_es_account_statement_import_n43: Define transaction reference (same as v13) #3284

merged 1 commit into from
Oct 31, 2023

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Oct 26, 2023 •
edited
Loading

Definir la referencia (ref) de las transacciones (similar a v13).

En v13 (https://github.com/OCA/l10n-spain/blob/13.0/l10n_es_account_bank_statement_import_n43/wizards/account_bank_statement_import_n43.py#L367) la referencia n43 se añadía a las transacciones y no queremos perder esa información ahora.

Por favor @pedrobaeza ¿puedes revisarlo?

@Tecnativa TT45629

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 14.0 milestone Oct 26, 2023
@pedrobaeza
Copy link
Member

¿Se pone entonces todo en la misma columna?

@victoralmau victoralmau force-pushed the 14.0-imp-l10n_es_account_statement_import_n43-TT45629 branch from acd457e to 3590161 Compare October 26, 2023 14:06
@victoralmau victoralmau changed the title [14.0][IMP] l10n_es_account_statement_import_n43: Add n43_ref to payment_ref of transactions (similar to v13) [14.0][IMP] l10n_es_account_statement_import_n43: Define transaction reference (same as v13) Oct 26, 2023
@victoralmau
Copy link
Member Author

Cambiado para que se añada la referencia en la columna que corresponde (igual que sucedía en v13).

@pedrobaeza
Copy link
Member

El otro hay que dejarlo como estaba: 4fb2933

y estoy revisando por qué se quitó lo de ref.

@victoralmau victoralmau force-pushed the 14.0-imp-l10n_es_account_statement_import_n43-TT45629 branch from 3590161 to b29a381 Compare October 26, 2023 14:14
@pedrobaeza
Copy link
Member

Vale, veo que han sido una serie de pasos que ha provocado esa consecuencia.

@pedrobaeza
Copy link
Member

Refleja por favor la explicación e historia en el mensaje de commit.

@victoralmau
[IMP] l10n_es_account_statement_import_n43: Define transaction refere…
a97a92a 
…nce (same as v13)

The reference was removed by mistake:
- Migration to 14.0 OCA@51181af#diff-f258811a1845bb979e1b791f3ba00780796578f57ce356f088cd176425b1aff2R366 (ref is changed to payment_ref)
- Remove name assignment (OCA@62f5186#diff-f258811a1845bb979e1b791f3ba00780796578f57ce356f088cd176425b1aff2R365) (payment_ref is now set with conceptos)
- Populate payment_ref if not conceptos: OCA@4fb2933

TT45629
@victoralmau victoralmau force-pushed the 14.0-imp-l10n_es_account_statement_import_n43-TT45629 branch from b29a381 to a97a92a Compare October 26, 2023 14:25
@victoralmau
Copy link
Member Author

Refleja por favor la explicación e historia en el mensaje de commit.

Hecho.

pedrobaeza
pedrobaeza approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-3284-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3bd5a94 into OCA:14.0 Oct 31, 2023
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 69c6598. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 14.0-imp-l10n_es_account_statement_import_n43-TT45629 branch October 31, 2023 08:41
@victoralmau victoralmau mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@victoralmau @OCA-git-bot @pedrobaeza