Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] AEF: Santander pide IBAN entero, incluidos digitos de control #3332

Merged
merged 1 commit into from
Jun 24, 2024
Merged

[14.0][FIX] AEF: Santander pide IBAN entero, incluidos digitos de control #3332

merged 1 commit into from
Jun 24, 2024

Conversation

giarve
Copy link
Contributor

@giarve giarve commented Dec 1, 2023

unnamed

Lo pongo en draft. Falta probar con Santander y los demás bancos... En la definición del AEF pone IBAN (alguna idea de por qué se descartan el codigo de pais y los 2 digitos de control actualmente? ESXX...)

@giarve giarve marked this pull request as ready for review December 4, 2023 18:49
@giarve
Copy link
Contributor Author

giarve commented Dec 4, 2023 •
edited
Loading

Funciona en Santander con este cambio.

Falta seguir probando los demás bancos (que no se rompan).

EDIT: funciona en bankinter

@giarve
Copy link
Contributor Author

giarve commented Jan 20, 2024

@pedrobaeza

Ya está probado en Bankinter, La Caixa y Sabadell en la 14.0

PR 15.0 #3348
PR 16.0 #3349

15.0 y 16.0 no están probadas en casos prácticos, pero no se si habrá grandes cambios

@pedrobaeza pedrobaeza mentioned this pull request Jun 3, 2024
Closed
@pedrobaeza pedrobaeza added this to the 14.0 milestone Jun 3, 2024
@pedrobaeza
Copy link
Member

Se tiene que probar en todos los bancos.

pedrobaeza
pedrobaeza approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probado y funcionando.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-3332-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 24, 2024
@OCA-git-bot
Merge PR #3332 into 14.0
04d81f3 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-3332-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-3332-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b6f669b into OCA:14.0 Jun 24, 2024
2 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 28478df. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@victoralmau victoralmau victoralmau approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@giarve @pedrobaeza @OCA-git-bot @victoralmau