[16.0][FIX] l10n_es_facturae: Fix addition of invoice PDF by adding encoding #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @etobella, |
Vulpino
force-pushed
the
15.0-IMP-l10n_es_facturae
branch
from
fe75ea9
to
74d4cf0
Compare
etobella
reviewed
Feb 5, 2024
| @@ -197,7 +197,7 @@ def _get_facturae_move_attachments(self): | |||
| ) | |||
| result.append( | |||
| { | |||
| "data": base64.b64encode(content), | |||
| "data": (base64.b64encode(content)).decode("utf-8"), | |||
There was a problem hiding this comment.
Suggested change
| "data": (base64.b64encode(content)).decode("utf-8"), | |
| "data": base64.b64encode(content).decode("utf-8"), |
El paréntesis no es necesario
etobella
changed the title
Vulpino
force-pushed
the
15.0-IMP-l10n_es_facturae
branch
from
cf76bf9
to
6a6a245
Compare
etobella
approved these changes
Feb 5, 2024
pedrobaeza
reviewed
Feb 5, 2024
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 7bfcf13. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.