Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] l10n_es_aeat_mod347: compañia incorrecta en plantilla de correo. #3433

Merged
merged 1 commit into from
Feb 9, 2024
Merged

[14.0][FIX] l10n_es_aeat_mod347: compañia incorrecta en plantilla de correo. #3433

merged 1 commit into from
Feb 9, 2024

Conversation

angelgarciadelachica
Copy link

El asunto de la plantilla del mensaje muestra el nombre de la compañía que tiene por defecto el usuario que envía el mensaje y no la compañía del informe que se está enviando.

Viene del PR #3426 en v13

@angelgarciadelachica
Copy link
Author

@HaraldPanten

HaraldPanten
HaraldPanten approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @pedrobaeza

@pedrobaeza pedrobaeza added this to the 14.0 milestone Feb 9, 2024
pedrobaeza
pedrobaeza reviewed Feb 9, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Siendo una plantilla noupdate="1", sin script de migración, este fix solo servirá para las nuevas instalaciones.

@angelgarciadelachica
Copy link
Author

@pedrobaeza Así es. El fix es para las nuevas instalaciones y para no ir arrastrando el error en versiones superiores (haré PR en v15 y v16). Puedo hacer un script de migración pero, ¿no ‘pisaría’ la plantilla que cada uno tenga customizada?

@pedrobaeza
Copy link
Member

Bueno, en este caso al tratarse del asunto, hay menos probabilidad que alguien lo haya personalizado. Entonces lo que veáis mejor. Bienvenido al mundo de tomar las decisiones menos malas, jeje.

@pedrobaeza
Copy link
Member

Un script sin efectos laterales sería uno que por código Python, en la plantilla correspondiente, y para cada idioma instalado, reemplace en el asunto ${user.company_id.name} por ${object.report_id.company_id.name}.

@angelgarciadelachica angelgarciadelachica force-pushed the 14.0-fix-l10n_es_aeat_mod347 branch 2 times, most recently from 3b6e6c2 to 24841e2 Compare February 9, 2024 12:58
pedrobaeza
pedrobaeza approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-3433-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e9b478c into OCA:14.0 Feb 9, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5ecec4a. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 14.0-fix-l10n_es_aeat_mod347 branch February 9, 2024 15:33
@pedrobaeza pedrobaeza mentioned this pull request Mar 4, 2024
Merged
@angelgarciadelachica angelgarciadelachica mentioned this pull request Apr 17, 2024
Merged
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@angelgarciadelachica @pedrobaeza @OCA-git-bot @HaraldPanten