Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] l10n_es_account_asset: Migration to 17.0 #3542

Merged
merged 51 commits into from
Jun 5, 2024

Conversation

manuelregidor
Copy link
Contributor

Standard migration
Depends on OCA/account-financial-tools#1819

anajuaristi and others added 30 commits April 22, 2024 07:50
…s prevision tesoreria y activos/amortizaciones.
…ron marcados como no instalables mientras no se compruebe que funcionan o migren, para poder usarlos o probarlos se debería poner el atributo installable de los ficheros __openerp__.py de cada módulo a True
…hecho para aprovechar el estándar al máximo.

* Incluido nuevo método de depreciación por porcentaje fijo.
* PEP8
* Icono del módulo
* Valor por defecto para ext_method_time
* Nos traemos unas corecciones aplicadas en la versión 7.0 que no estaban en la 8.0, necesarias para hacer correctamente amortizaciones mensuales sin prorrata.
…sual ya incuidas en 7.0 + arreglado problema en la vista para la fecha de inicio de cálculo
…e + remove # depreciations compensation. Fixes OCA#146 +  Delete empty last depreciation line
…category_id (OCA#671)

Pasos para reproducir el error:

* Crear un tipo de activo
* Al crear un nuevo activo, los datos de la periodicidad configurados en el tipo de activo no se importan al nuevo activo.

Corrección:
El método a sobreescribir debe ser el "onchange_category_id_values" y no el "onchange_category_id" tal y como es actualmente.
…CA#804)

Corregido _compute_board_undone_dotation_nb para casos de prorrateo
…sset_management

As `account_asset` is now enterprise, we switch the dependency to `account_asset_management`
OCA module.

This requires a heavy refactoring on code and tests, but with some hooks and fixes provided
to OCA module, it's still very light.

Other changes:

* README by fragments
* Promote to Production/Stable
* Set maintainer
Currently translated at 100.0% (9 of 9 strings)

Translation: l10n-spain-12.0/l10n-spain-12.0-l10n_es_account_asset
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-l10n_es_account_asset/es/
In some cases, the amount in annual_percentage is not synchronized with the one
in the period one due to a non hunted bug in v10/v11.

As in v12 now the important field is the annual one, we must synchronize it properly.
@manuelregidor manuelregidor force-pushed the 17.0-mig-l10n_es_account_asset branch 4 times, most recently from dbdad9f to 2084f0c Compare April 22, 2024 07:01
@HaraldPanten
Copy link
Contributor

/ocabot migration l10n_es_account_asset

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Apr 24, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 24, 2024
47 tasks
@Jesarregui
Copy link
Contributor

@HaraldPanten Lo pruebo yo

Copy link
Contributor

@Jesarregui Jesarregui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Revisión funcional.
Puntos combrobados:

La creación de un activo "en frío" desde el módulo de activos.
La creación del activo desde facturas de compra.
La venta del activo.
El cálculo de amortización.
La venta/eliminación del activo.

@HaraldPanten
Copy link
Contributor

@manuelregidor Puedes hacer rebase? La dependencia ya ha sido fusionada.

@manuelregidor manuelregidor force-pushed the 17.0-mig-l10n_es_account_asset branch from 2084f0c to a3c7a04 Compare June 3, 2024 06:53
@manuelregidor manuelregidor force-pushed the 17.0-mig-l10n_es_account_asset branch from a3c7a04 to c98629f Compare June 3, 2024 06:54
@manuelregidor
Copy link
Contributor Author

@HaraldPanten @Jesarregui Podéis revisar? Gracias.

Copy link
Contributor

@Jesarregui Jesarregui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pedrobaeza @ValentinVinagre Podéis hacer revisión técnica?

Gracias.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-3542-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 5, 2024
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-3542-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0068a88 into OCA:17.0 Jun 5, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 52dbf6e. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-l10n_es_account_asset branch June 5, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.