Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] l10n_es_location_nuts: Migration to 17.0 #3673

Merged
merged 20 commits into from
Jul 24, 2024
Merged

[17.0][MIG] l10n_es_location_nuts: Migration to 17.0 #3673

merged 20 commits into from
Jul 24, 2024

Conversation

FernandoRomera
Copy link
Contributor

@FernandoRomera FernandoRomera commented Jul 19, 2024 •
edited
Loading

Antonio Espinosa and others added 19 commits July 19, 2024 08:47
@FernandoRomera
[ADD] Add l10n_es_location_nuts addon
ee0a1b0
@yajo @FernandoRomera
Give toponyms wizard the right priority.
975280e 
This will make it be executed before the NUTS import wizard.

See OCA#150 (comment)
@antespi @FernandoRomera
Complete spanish translation
901e3b7
@antespi @FernandoRomera
Use separate and explicit fields for each NUTS level
d66d712
@chienandalu @FernandoRomera
[MIG] l10n_es_location_nuts: Migration to 10.0
90b7121
@FernandoRomera
[MIG] l10n_es_location_nuts: Migration to 11.0
88457b7
@Tardo @FernandoRomera
[MIG] l10n_es_location_nuts: Migration to 12.0
15fb75c
@FernandoRomera
[IMP] l10n_es_location_nuts: black, isort, prettier
d91fd3f
@FernandoRomera
[MIG] l10n_es_location_nuts: Migration to 14.0
de74a06
@FernandoRomera
[UPD] Update l10n_es_location_nuts.pot
35b04d8
@OCA-git-bot @FernandoRomera
[UPD] README.rst
16a140d
@extrememicro @FernandoRomera
Added translation using Weblate (Catalan)
f05bcc9
@OCA-git-bot @FernandoRomera
[UPD] README.rst
ad09291
@weblate @FernandoRomera
Update translation files
ee6ab79 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-14.0/l10n-spain-14.0-l10n_es_location_nuts
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-l10n_es_location_nuts/
@Ivorra78 @FernandoRomera
Translated using Weblate (Spanish)
df0a6ac 
Currently translated at 100.0% (4 of 4 strings)

Translation: l10n-spain-14.0/l10n-spain-14.0-l10n_es_location_nuts
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-l10n_es_location_nuts/es/
@edlopen @FernandoRomera
[16.0][MIG] l10n_es_location_nuts
5ebc430 
@moduon MT-1811
@FernandoRomera
[UPD] Update l10n_es_location_nuts.pot
6bee1ff
@OCA-git-bot @FernandoRomera
[BOT] post-merge updates
1960b04
@FernandoRomera
[IMP] l10n_es_location_nuts: pre-commit auto fixes
91e518b
@pedrobaeza pedrobaeza changed the title [17.0][MIG] l10n es location nuts: Migration to 17.0 [17.0][MIG] l10n_es_location_nuts: Migration to 17.0 Jul 19, 2024
@FernandoRomera
Copy link
Contributor Author

@pedrobaeza gracias por corregir el titulo, se me pasaron los espacios.

@pedrobaeza
Copy link
Member

Puedes también comprobar el CI mientras se fusiona la dependencia:

https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

Es conveniente también reflejar dicha dependencia en el comentario principal.

@HaraldPanten
Copy link
Contributor

/ocabot migration l10n_es_location_nuts

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 22, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 22, 2024
Open
47 tasks
@HaraldPanten
Copy link
Contributor

@FernandoRomera ya puedes hacer rebase. Fusionada la dependencia

@FernandoRomera FernandoRomera force-pushed the 17.0-mig-l10n_es_location_nuts branch 2 times, most recently from bc7333c to 7ead765 Compare July 24, 2024 06:49
@FernandoRomera
Copy link
Contributor Author

@HaraldPanten Gracias.
Hecho el rebase.

HaraldPanten
HaraldPanten requested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisión funcional OK, pero tienes que quitar el número de versión en el commit de migración:

Captura de Pantalla 2024-07-24 a las 9 28 39

@FernandoRomera
Copy link
Contributor Author

@HaraldPanten
Perdona, pensaba que el titulo de commit de migración era el mismo que el titulo del PR.
Hecho.

@HaraldPanten
Copy link
Contributor

@HaraldPanten Perdona, pensaba que el titulo de commit de migración era el mismo que el titulo del PR. Hecho.

Sin problema, es casi igual, pero no debes poner la versión.

AntoniRomera
AntoniRomera approved these changes Jul 24, 2024
View reviewed changes
Copy link

@AntoniRomera AntoniRomera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AntoniRomera
AntoniRomera approved these changes Jul 24, 2024
View reviewed changes
Copy link

@AntoniRomera AntoniRomera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-3673-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 61809eb into OCA:17.0 Jul 24, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c0d5edc. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@AntoniRomera AntoniRomera AntoniRomera approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.