Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] [MIG] l10n_ch_account_tags: Migration to 14.0 #615

Merged
merged 21 commits into from
Sep 17, 2021

Conversation

sonhd91
Copy link

@sonhd91 sonhd91 commented Sep 9, 2021

No description provided.

mpanarin and others added 20 commits September 9, 2021 00:06
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-switzerland-12.0/l10n-switzerland-12.0-l10n_ch_account_tags
Translate-URL: https://translation.odoo-community.org/projects/l10n-switzerland-12-0/l10n-switzerland-12-0-l10n_ch_account_tags/
Split the csv by type of operation: update and new

In update reduce the number of columns to only set the tags
Column name and column user_type_id were overwriting
account template with bad values.

Also sort account.account.template in the csv file.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-switzerland-13.0/l10n-switzerland-13.0-l10n_ch_account_tags
Translate-URL: https://translation.odoo-community.org/projects/l10n-switzerland-13-0/l10n-switzerland-13-0-l10n_ch_account_tags/
@sonhd91 sonhd91 marked this pull request as draft September 9, 2021 03:58
@sonhd91 sonhd91 mentioned this pull request Sep 9, 2021
14 tasks
Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I don't think we need to new commit for the migration.

l10n_ch_account_tags/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
@sonhd91 sonhd91 force-pushed the 14.0-mig-l10n_ch_account_tags branch 5 times, most recently from 16bb03f to 2380ca4 Compare September 10, 2021 08:25
@sonhd91
Copy link
Author

sonhd91 commented Sep 10, 2021

The commit [MIG] add commit from 14-fix-base-bank-test... will be remove after PR#616 merged

@sonhd91 sonhd91 marked this pull request as ready for review September 10, 2021 09:37
Copy link
Member

@mmequignon mmequignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for this one to be merged #616 (review)
I pre-approve.

Copy link

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG but please fix .pre-commit file and drop the last commit as #616 is gettting merged

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@sonhd91 sonhd91 force-pushed the 14.0-mig-l10n_ch_account_tags branch 2 times, most recently from 2380ca4 to b3e1ce7 Compare September 16, 2021 05:15
@sonhd91 sonhd91 force-pushed the 14.0-mig-l10n_ch_account_tags branch from b3e1ce7 to 85f85d0 Compare September 16, 2021 05:21
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-615-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3d6cea8 into OCA:14.0 Sep 17, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9f20fb7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants