Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] [8.0] l10n_ch_payment_slip_voucher #86

Merged
merged 15 commits into from
Apr 15, 2015

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Jan 21, 2015

we have some small customers which find vouchers convenient. The same small customers usually apply the VAT on payment regime.
So, we created this module mainly to apply the VAT on payment regime (that at the moment is voucher based)

@nbessi
Copy link
Contributor

nbessi commented Jan 21, 2015

@fclementic2c can you please do a business review

@coveralls
Copy link

Coverage Status

Coverage increased (+1.54%) when pulling 4793664 on eLBati:add_l10n_ch_payment_slip_voucher_2 into d8830cd on OCA:8.0.

from . import test_v11_import
fast_suite = [
test_v11_import
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast_suite is no longer used in v8 and should be removed (tests are loaded as soon as they are imported in this file)

@guewen
Copy link
Member

guewen commented Jan 22, 2015

I guess you had had a pleasant time dealing with the voucher's api 😁
👍 (a few minor remarks)

@eLBati
Copy link
Member Author

eLBati commented Jan 29, 2015

Thanks @guewen I made some improvements

@coveralls
Copy link

Coverage Status

Coverage increased (+1.54%) to 73.16% when pulling 61798c8 on eLBati:add_l10n_ch_payment_slip_voucher_2 into d8830cd on OCA:8.0.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.54%) to 73.16% when pulling bb018ec on eLBati:add_l10n_ch_payment_slip_voucher_2 into d8830cd on OCA:8.0.

@eLBati eLBati force-pushed the add_l10n_ch_payment_slip_voucher_2 branch from bb018ec to 81d2701 Compare February 3, 2015 15:06
@eLBati eLBati force-pushed the add_l10n_ch_payment_slip_voucher_2 branch from 81d2701 to 1834f57 Compare February 17, 2015 11:38
@nbessi
Copy link
Contributor

nbessi commented Feb 25, 2015

@fclementic2c any news on this one

@nbessi
Copy link
Contributor

nbessi commented Mar 31, 2015

👍

@nbessi
Copy link
Contributor

nbessi commented Mar 31, 2015

For me it is fine. As soon @fclementic2c confirms it is correct in term of business we can merge

@fclementic2c
Copy link
Member

I do not have time to test sorry. My worry is :

  • Does it work in case of multicurrency with a currency difference ?
  • Does it work in case of multicurrency and partial payment ?

@eLBati eLBati force-pushed the add_l10n_ch_payment_slip_voucher_2 branch from 1834f57 to fa4cf80 Compare April 1, 2015 06:40
@eLBati
Copy link
Member Author

eLBati commented Apr 1, 2015

Hello @fclementic2c , currency is selected in wizard and set in voucher as is.
Then, to handle currency differences and partial payments in case of multi currency is a voucher task.
Do you see problems with that?

@coveralls
Copy link

Coverage Status

Coverage increased (+1.54%) to 72.92% when pulling 43531e5 on eLBati:add_l10n_ch_payment_slip_voucher_2 into 733a5c1 on OCA:8.0.

@nbessi
Copy link
Contributor

nbessi commented Apr 15, 2015

Ok seen with @fclementic2c

nbessi added a commit that referenced this pull request Apr 15, 2015
@nbessi nbessi merged commit 1a33876 into OCA:8.0 Apr 15, 2015
yvaucher pushed a commit to yvaucher/l10n-switzerland that referenced this pull request Nov 14, 2017
vrenaville pushed a commit to camptocamp/l10n-switzerland that referenced this pull request Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants