Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0] [MIG] maintenance_plan #12

Merged
merged 4 commits into from
Jul 3, 2019
Merged

[11.0] [MIG] maintenance_plan #12

merged 4 commits into from
Jul 3, 2019

Conversation

dalonsod
Copy link
Contributor

@dalonsod dalonsod commented Jul 1, 2019

Superseeds #11 , fixes cron job issue with demo data

@pedrobaeza pedrobaeza requested a review from astirpe July 1, 2019 15:22
@pedrobaeza pedrobaeza added this to the 11.0 milestone Jul 1, 2019
astirpe
astirpe requested changes Jul 2, 2019
View reviewed changes
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Runbot, the issue with the cron and demo data is fixed. Thanks!

maintenance_plan/__manifest__.py Outdated Show resolved Hide resolved
@astirpe
Copy link
Member

astirpe commented Jul 2, 2019

@pedrobaeza it seems to me that tests are not executed at all in this V11 branch. In there something wrong in the configuration of this repo?

@pedrobaeza
Copy link
Member

That's because https://github.com/OCA/maintenance/blob/7e6854e8f25654cd4a357e8877905f3c7ed021ce/maintenance_plan/tests/__init__.py is empty and it's not importing test file.

@dalonsod
Copy link
Contributor Author

dalonsod commented Jul 3, 2019

OK, one test is not passed yet. I'll fix it

@astirpe
Copy link
Member

astirpe commented Jul 3, 2019

Thanks @pedrobaeza
@dalonsod thanks, you should be mentioned in the contributors list of the README as well

@dalonsod
Copy link
Contributor Author

dalonsod commented Jul 3, 2019

@astirpe it seems everything's ok. Could you check?

astirpe
astirpe approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried on Runbot: seems working fine. Thanks!

@pedrobaeza pedrobaeza mentioned this pull request Jul 3, 2019
Closed
4 tasks
@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Rebased to 11.0-ocabot-merge-pr-12-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1478625 into OCA:11.0 Jul 3, 2019
OCA-git-bot added a commit that referenced this pull request Jul 3, 2019
@OCA-git-bot
Merge PR #12 into 11.0
4057b11 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4057b11. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@astirpe astirpe astirpe approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
6 participants
@dalonsod @astirpe @pedrobaeza @OCA-git-bot @grindtildeath @bestmazzo