[11.0][MIG] base_maintenance_config (split in 2 separate modules) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pedrobaeza one month before my approval, this PR wasn't automatically marked as approved. Is there any missing configuration in this repo, or is this the expected behavior? |
|
It requires 2 approvals. |
|
Thanks, @pedrobaeza |
jarroyomorales
approved these changes
Nov 6, 2019
|
This PR has the |
|
/ocabot merge |
|
What a great day to merge this nice PR. Let's do it! |
OCA-git-bot
added a commit
that referenced
this pull request
Nov 6, 2019
|
Congratulations, your PR was merged at f3bb69a. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While porting
base_maintenance_configto V11, I'm splitting it in two different modules:base_maintenance_config, containing only the general configuration view;base_maintenance_group, containing all the stuff related the newly added groups.