-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10.0 mig mgmtsystem hazard risk #232
Conversation
mgmtsystem_hazard/README.rst
Outdated
|
||
.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
:alt: Try me on Runbot | ||
:target: https://runbot.odoo-community.org/runbot/128/9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/10.0
mgmtsystem_hazard/README.rst
Outdated
If you spotted it first, help us smashing it by providing a detailed and welcomed feedback `here <https://github.com/OCA/ | ||
management-system/issues/new?body=module:%20 | ||
mgmtsystem_hazard%0Aversion:%20 | ||
9.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10.0
2cca0b2
to
2a91def
Compare
Checks of coverage failed but how can I avoid that ? I just changed what was necessary for the migration. Could it come from the fact that I migrated directly from 8.0 to 10.0 ? |
@ngrandjean You would need to add new tests that execute the lines of code that are not currently covered. |
Hey @ngrandjean, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
2 similar comments
Hey @ngrandjean, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
Hey @ngrandjean, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
0fdef98
to
2a91def
Compare
Hey @ngrandjean, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
I tried to add some tests but it didn't change anything for the coverage check (so I reverted that commit). What puzzles me is that the code didn't really change since the first tests where added. |
Missing dependency :
mgmtsystem_hazard
#159