Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.0 mig mgmtsystem hazard risk #232

Merged
merged 12 commits into from
May 5, 2019

Conversation

ngrandjean
Copy link

@ngrandjean ngrandjean commented Sep 5, 2018

Missing dependency :
mgmtsystem_hazard

#159

@pedrobaeza pedrobaeza added this to the 10.0 milestone Sep 5, 2018
@max3903 max3903 self-requested a review October 17, 2018 13:22
@pedrobaeza pedrobaeza mentioned this pull request Oct 17, 2018
31 tasks

.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/128/9.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/10.0

If you spotted it first, help us smashing it by providing a detailed and welcomed feedback `here <https://github.com/OCA/
management-system/issues/new?body=module:%20
mgmtsystem_hazard%0Aversion:%20
9.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10.0

@ngrandjean ngrandjean force-pushed the 10.0-mig-mgmtsystem_hazard_risk branch from 2cca0b2 to 2a91def Compare October 18, 2018 13:25
@ngrandjean
Copy link
Author

Checks of coverage failed but how can I avoid that ? I just changed what was necessary for the migration. Could it come from the fact that I migrated directly from 8.0 to 10.0 ?

@max3903
Copy link
Member

max3903 commented Oct 19, 2018

@ngrandjean You would need to add new tests that execute the lines of code that are not currently covered.

@oca-clabot
Copy link

Hey @ngrandjean, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

2 similar comments
@oca-clabot
Copy link

Hey @ngrandjean, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@oca-clabot
Copy link

Hey @ngrandjean, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@ngrandjean ngrandjean force-pushed the 10.0-mig-mgmtsystem_hazard_risk branch from 0fdef98 to 2a91def Compare December 5, 2018 10:10
@oca-clabot
Copy link

Hey @ngrandjean, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@ngrandjean
Copy link
Author

I tried to add some tests but it didn't change anything for the coverage check (so I reverted that commit). What puzzles me is that the code didn't really change since the first tests where added.
Can someone help me with that ?
Thanks

@max3903 max3903 merged commit 2ccfa93 into OCA:10.0 May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants