[REF] 8.0 mgmtsystem hazard

[llacroix]

Changed nothing and it seems to work

Depends on:

• [REF] mgmtsystem #20

[coveralls]

Coverage decreased (-20.93%) when pulling 3e6d26c on savoirfairelinux:8.0-mgmtsystem_hazard into d10997c on OCA:8.0.

[bwrsandman]

Needs tests

[llacroix]

Ok going to add tests

[coveralls]

Coverage decreased (-11.75%) to 85.93% when pulling 1a043d0 on savoirfairelinux:8.0-mgmtsystem_hazard into fba5b14 on OCA:8.0.

[llacroix]

The problem in this PR is that it tries to set a field as required on res_company without setting a default value during an alter table. Existing records will trigger a constraint error.

2015-04-01 10:12:24,162 16655 INFO 2925915-28-1a043d-all openerp.modules.module: module mgmtsystem_hazard: creating or updating database tables
2015-04-01 10:12:29,983 16655 ERROR 2925915-28-1a043d-all openerp.sql_db: bad query: ALTER TABLE "res_company" ALTER COLUMN "risk_computation_id" SET NOT NULL
Traceback (most recent call last):
      File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/2925915-28-1a043d/openerp/sql_db.py", line 234, in execute
res = self._obj.execute(query, params)
IntegrityError: column "risk_computation_id" contains null values

2015-04-01 10:12:29,985 16655 WARNING 2925915-28-1a043d-all openerp.models: WARNING: unable to set column risk_computation_id of table res_company not null !
Try to re-run: openerp-server --update=module
If it doesn't work, update records and execute manually:
ALTER TABLE res_company ALTER COLUMN risk_computation_id SET NOT NULL
Traceback (most recent call last):
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/2925915-28-1a043d/openerp/models.py", line 2643, in _auto_init
cr.execute('ALTER TABLE "%s" ALTER COLUMN "%s" SET NOT NULL' % (self._table, k))
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/2925915-28-1a043d/openerp/sql_db.py", line 158, in wrapper
return f(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/2925915-28-1a043d/openerp/sql_db.py", line 234, in execute
    res = self._obj.execute(query, params)
IntegrityError: column "risk_computation_id" contains null values

We have to decide between adding a default value and keeping it required=True, or set it required=False and update some views with require on certain states.

[max3903]

You can set A * B * C as the default value and add this configuration step in the README.rst

[coveralls]

Coverage decreased (-6.35%) to 93.65% when pulling d61687d on savoirfairelinux:8.0-mgmtsystem_hazard into 49cc23b on OCA:8.0.

[bwrsandman]

Needs test for:

• mgmtsystem_hazard_risk/models/res_company.py risk_computation_id
• mgmtsystem_hazard_risk/models/mgmtsystem_hazard.py risk
• mgmtsystem_hazard_risk/models/mgmtsystem_hazard_residual_risk.py risk

[ghost]

@max3903 @bwrsandman It seems that these modules are not multi-system at all and the multi-company seems incomplete. I think that most models should have both a system_id field and a company_id field (related to the company of the system). For example, the risk formula is taken from the user's company. It would make more sence to take it from the system related to the mgmtsystem.hazard record.

[max3903]

@dufresnedavid Very true, but this is the lowest priority.

[max3903]

👍

[yvaucher]

Description must go in README.rst

[yvaucher]

Size shouldn't be specified

[yvaucher]

just few remarks otherwise 👍 (code review + french translations)

[dreispt]

Multi-system and multi-company support should be mentioned in the Roadmap section, then.

[dreispt]

drop size

[dreispt]

Build green, two approvals, remarks fixed - I would merge but it needs a rebase!