Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] 8.0 mgmtsystem survey #30

Merged
merged 9 commits into from
Apr 14, 2015
Merged

Conversation

llacroix
Copy link

Added mgmtsystem as a dependency and fix some of the changes in the survey API.

Removed action related to survey.action_browse_survey_response as it doesn't seem to exist anymore.

Depends on:

<menuitem id="menu_open_answers"
name="Survey Answers"
action="survey.action_browse_survey_response"
parent="mgmtsystem.menu_mgmtsystem_main"
sequence="90"
groups="base.group_user"/>
-->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to remove this altogether

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9fc49b7 on savoirfairelinux:8.0-mgmtsystem-survey into d10997c on OCA:8.0.

@dreispt
Copy link
Member

dreispt commented Nov 21, 2014

The icon location has changed in v8, so it shouldn't be at mgmtsystem_survey/static/src/img anymore. The icon should be at mgmtsystem_survey/static/description.

@bwrsandman bwrsandman added this to the 8.0 milestone Nov 24, 2014
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 419aa54 on savoirfairelinux:8.0-mgmtsystem-survey into d10997c on OCA:8.0.

@@ -3,14 +3,14 @@

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this file by model

  • data/survey_stage_data.xml
  • data/survey_survey_data.xml
  • data/survey_question_data.xml
  • views/survey_survey_view.xml

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.67% when pulling 14f6efa on savoirfairelinux:8.0-mgmtsystem-survey into fba5b14 on OCA:8.0.

@llacroix llacroix mentioned this pull request Apr 1, 2015
2 tasks
@llacroix
Copy link
Author

llacroix commented Apr 1, 2015

Coverage 100% except mgmtsystem, check #64

@llacroix llacroix changed the title [REF] 8.0 mgmtsystem survey [REF] 8.0 mgmtsystem survey [needs review] Apr 1, 2015
@dreispt dreispt changed the title [REF] 8.0 mgmtsystem survey [needs review] [REF] 8.0 mgmtsystem survey Apr 8, 2015
@@ -0,0 +1,13 @@
<openerp>
<data>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noupdate="1" or set it as demo data

@llacroix
Copy link
Author

llacroix commented Apr 8, 2015

As for the data part, I'll check with max what we really want here.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8dfd21e on savoirfairelinux:8.0-mgmtsystem-survey into 9a7db5d on OCA:8.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8dfd21e on savoirfairelinux:8.0-mgmtsystem-survey into 9a7db5d on OCA:8.0.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8dfd21e on savoirfairelinux:8.0-mgmtsystem-survey into 9a7db5d on OCA:8.0.

@dreispt
Copy link
Member

dreispt commented Apr 10, 2015

@llacroix This is WIP, right?

@llacroix
Copy link
Author

@dreispt Yes, I'll update the data demo thing. I'll update the PR later today

@llacroix
Copy link
Author

@dreispt I made the changes, but I feel something is wrong with the demo data. Some fields seems to be missing in the new survey model. The runbot build is warning about some missing fields.

2015-04-09 20:12:43,111 6032 WARNING 2926268-30-8dfd21-all openerp.models: 
survey.question.create() with unknown fields: 
in_visible_answer_type, in_visible_menu_choice, in_visible_rating_weight

Those fields probably got renamed or removed.

@max3903
Copy link
Member

max3903 commented Apr 10, 2015

@llacroix just remove them from the demo data

Otherwise, I have tested on runbot
👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1785a12 on savoirfairelinux:8.0-mgmtsystem-survey into 9a7db5d on OCA:8.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1785a12 on savoirfairelinux:8.0-mgmtsystem-survey into 9a7db5d on OCA:8.0.

@dreispt
Copy link
Member

dreispt commented Apr 14, 2015

👍

dreispt added a commit that referenced this pull request Apr 14, 2015
@dreispt dreispt merged commit b15ec43 into OCA:8.0 Apr 14, 2015
@max3903 max3903 deleted the 8.0-mgmtsystem-survey branch April 14, 2015 12:52
@max3903 max3903 mentioned this pull request Apr 14, 2015
26 tasks
tschanzt pushed a commit to camptocamp/management-system that referenced this pull request Jun 26, 2019
BSCOS-151: Change columns in res.partner List view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants