Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0] [MIG] mgmtsystem_action #589

Merged
merged 5 commits into from
Sep 23, 2024
Merged

[17.0] [MIG] mgmtsystem_action #589

merged 5 commits into from
Sep 23, 2024

Conversation

m1k3lm
Copy link
Member

@m1k3lm m1k3lm commented May 21, 2024

No description provided.

@m1k3lm m1k3lm mentioned this pull request May 21, 2024
Closed
@m1k3lm
Copy link
Member Author

m1k3lm commented May 21, 2024

@mymage should the test coverage be fixed in the same PR as the migration?

@mymage
Copy link
Member

mymage commented May 22, 2024

@mymage should the test coverage be fixed in the same PR as the migration?

I don't know really what is the actual policy.
I had similar conditions in other migration PRs and I did my best to have all green.
If I remembe well some PSC merged it with some CodeCov not green.
So if you can and it is "simple" to complete the CodeCov, do it. If you do not reach the result, place here a message to [@]OCA/management-systems-maintainers.

@mymage
Copy link
Member

mymage commented May 22, 2024

@m1k3lm ... but the pandoc file is still here :-(

@m1k3lm m1k3lm mentioned this pull request May 22, 2024
Open
30 tasks
@m1k3lm
Copy link
Member Author

m1k3lm commented May 31, 2024

@m1k3lm ... but the pandoc file is still here :-(

Sorry, @mymage already deleted.

@m1k3lm m1k3lm force-pushed the 17.0-mgmtsystem_action branch 6 times, most recently from 9e0d6b4 to 2bf8c02 Compare June 1, 2024 17:08
mymage
mymage approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@mymage mymage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@max3903 max3903 added this to the 17.0 milestone Sep 19, 2024
@max3903 max3903 self-assigned this Sep 21, 2024
@max3903
Copy link
Member

max3903 commented Sep 23, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-589-by-max3903-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9de8170 into OCA:17.0 Sep 23, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4d02503. Thanks a lot for contributing to OCA. ❤️

@max3903
Copy link
Member

max3903 commented Sep 24, 2024

/ocabot migration mgmtsystem_action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mymage mymage mymage approved these changes

@max3903 max3903 max3903 approved these changes

Assignees

@max3903 max3903

Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@m1k3lm @mymage @max3903 @OCA-git-bot @DiegoFJ95