[15.0][MIG] account_invoice_margin_sale_delivered_sync: Migration to version 15.0 #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to non update delivered margin on posted invoices TT37653
|
/ocabot migration account_invoice_margin_sale_delivered_sync |
sergio-teruel
suggested changes
Mar 6, 2023
| @@ -7,7 +7,7 @@ | |||
| class SaleOrderLine(models.Model): | |||
| _inherit = "sale.order.line" | |||
|
|
|||
| def _prepare_invoice_line(self): | |||
| def _prepare_invoice_line(self, **optional_values): | |||
| vals = super()._prepare_invoice_line() | |||
There was a problem hiding this comment.
You are breaking the method.. you must pass optional_values
ernestotejeda
force-pushed
the
15.0-mig-account_invoice_margin_sale_delivered_sync
branch
from
468515d
to
c6b356f
Compare
sergio-teruel
approved these changes
Mar 6, 2023
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
chienandalu
approved these changes
Mar 6, 2023
|
Congratulations, your PR was merged at 4362833. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cc @Tecnativa TT38304