Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_invoice_margin_sale: Migration to 16.0 #165

Merged
merged 12 commits into from
Jun 5, 2023
Merged

[16.0][MIG] account_invoice_margin_sale: Migration to 16.0 #165

merged 12 commits into from
Jun 5, 2023

Conversation

ljsalvatierra-factorlibre
Copy link

@ljsalvatierra-factorlibre ljsalvatierra-factorlibre commented Mar 13, 2023 •
edited
Loading

@ljsalvatierra-factorlibre ljsalvatierra-factorlibre force-pushed the 16.0-mig-account_invoice_margin_sale branch 2 times, most recently from 154d075 to f494b85 Compare May 30, 2023 06:45
@Gelo-fl
Copy link

Gelo-fl commented Jun 2, 2023

@ljsalvatierra-factorlibre runboat does not work to be able to test it.

@ljsalvatierra-factorlibre
Copy link
Author

@ljsalvatierra-factorlibre runboat does not work to be able to test it.

I think its because the dependency is not merged yet.

@rafaelbn
Copy link
Member

rafaelbn commented Jun 3, 2023

/ocabot migration account_invoice_margin_sale

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 3, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 3, 2023
Open
10 tasks
@rafaelbn
Copy link
Member

rafaelbn commented Jun 3, 2023

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@rafaelbn The rebase process failed, because command git push --force factorlibre tmp-pr-165:16.0-mig-account_invoice_margin_sale failed with output:

remote: Permission to factorlibre/margin-analysis.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/factorlibre/margin-analysis/': The requested URL returned error: 403

@rafaelbn
Copy link
Member

rafaelbn commented Jun 3, 2023

Please @ljsalvatierra-factorlibre rebase! 😄 dependency is merged!

@RodrigoBM
Copy link

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Sorry @RodrigoBM you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

oca-travis and others added 10 commits June 5, 2023 09:32
@oca-travis @ljsalvatierra-factorlibre
[UPD] Update account_invoice_margin_sale.pot
b900953
@HaraldPanten @ljsalvatierra-factorlibre
Added translation using Weblate (Spanish)
72fea69
@HaraldPanten @ljsalvatierra-factorlibre
Translated using Weblate (Spanish)
a68fcc2 
Currently translated at 100.0% (1 of 1 strings)

Translation: margin-analysis-13.0/margin-analysis-13.0-account_invoice_margin_sale
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-13-0/margin-analysis-13-0-account_invoice_margin_sale/es/
@ljsalvatierra-factorlibre
[IMP] skip margin calculation for Down Payment invoice
a1232ec 
[UPD] Update account_invoice_margin_sale.pot

[UPD] README.rst

account_invoice_margin_sale 13.0.1.0.1

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: margin-analysis-13.0/margin-analysis-13.0-account_invoice_margin_sale
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-13-0/margin-analysis-13-0-account_invoice_margin_sale/
@Reyes4711-S73 @ljsalvatierra-factorlibre
[14.0][MIG] account_invoice_margin_sale: Migration to 14.0
2f25008 
[UPD] Update account_invoice_margin_sale.pot

[UPD] README.rst
@rafamarpe @ljsalvatierra-factorlibre
Translated using Weblate (Spanish)
bfdb551 
Currently translated at 100.0% (3 of 3 strings)

Translation: margin-analysis-14.0/margin-analysis-14.0-account_invoice_margin_sale
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-14-0/margin-analysis-14-0-account_invoice_margin_sale/es/
@victoralmau @ljsalvatierra-factorlibre
[MIG] account_invoice_margin_sale: Migration to 15.0
cfdfb52 
TT36420
@ljsalvatierra-factorlibre
[UPD] Update account_invoice_margin_sale.pot
1ff371f
@OCA-git-bot @ljsalvatierra-factorlibre
[UPD] README.rst
20f8ba8
@ljsalvatierra-factorlibre
[IMP] account_invoice_margin_sale: pre-commit stuff
9d34172
@ljsalvatierra-factorlibre
Copy link
Author

Please @ljsalvatierra-factorlibre rebase! smile dependency is merged!

Done, apologies for the delay.

@ljsalvatierra-factorlibre
Copy link
Author

Still WIP awaiting functional review.

@RodrigoBM
Copy link

ping @rafaelbn @fcvalgar

fcvalgar
fcvalgar approved these changes Jun 5, 2023
View reviewed changes
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review including user permissions.

LGTM, thankx @ljsalvatierra-factorlibre

image

@ljsalvatierra-factorlibre
Copy link
Author

Functional review including user permissions.

LGTM, thankx @ljsalvatierra-factorlibre

image

thank you :)

Still pending review from @Gelo-fl

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-165-by-pedrobaeza-bump-nobump, awaiting test results.

@pedrobaeza pedrobaeza changed the title [WIP][16.0][MIG] account_invoice_margin_sale: Migration to 16.0 [16.0][MIG] account_invoice_margin_sale: Migration to 16.0 Jun 5, 2023
@OCA-git-bot OCA-git-bot merged commit f2fc1c8 into OCA:16.0 Jun 5, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4a71c52. Thanks a lot for contributing to OCA. ❤️

@ljsalvatierra-factorlibre ljsalvatierra-factorlibre deleted the 16.0-mig-account_invoice_margin_sale branch June 5, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RodrigoBM RodrigoBM RodrigoBM approved these changes

@fcvalgar fcvalgar fcvalgar approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.