Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] product_pricelist_margin: Migration to version 16.0 #168 #173 #177

Closed

Conversation

hugo-cordoba
Copy link

[16.0][MIG] product_pricelist_margin

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HugoCordobaLeal. Thanks for porting this module.

Unfortunately, this module is obsolete, and should not be ported.
See : OCA/product-attribute#1114 (comment)

The objective, in V16 is to develop a module named product_pricelist_simulation_margin on top of the module product_pricelist_simulation. That is a base module to simulate pricelist prices.

I'm OK to develop this module.

@pedrobaeza, ernestotejeda : did you planned to migrate product_pricelist_simulation in V16 ?

@hugo-cordoba hugo-cordoba changed the title 16.0 mig product pricelist margin [16.0][MIG] product_pricelist_margin: Migration to version 16.0 #168 #173 Jun 6, 2023
@hugo-cordoba
Copy link
Author

Good morning.

Ok, the migration is not finished yet, I would have to modify some things and fix the tests. I didn't know there was another intention in v16. If the new version requires to develop the module 'product_pricelist_simulation_margin', I offer to be the author of that module.

What do you think about @pedrobaeza ?

cc/ @legalsylvain

@pedrobaeza
Copy link
Member

Go ahead, Hugo! Please check how product_pricelist_simulation is working now, and the new module will be trivial adding the column.

@legalsylvain
Copy link
Contributor

@pedrobaeza : product_pricelist_simulation is available for V16 ? I didn't found it any pending work.

For me the last available version is in V13, and there is a dead PR for V14 here.

@pedrobaeza
Copy link
Member

Well, then migrating that module is a pre-requisite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants