Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] mis_builder_budget_product: Migration to 16.0 #36

Merged
merged 5 commits into from
Aug 1, 2023
Merged

[16.0][MIG] mis_builder_budget_product: Migration to 16.0 #36

merged 5 commits into from
Aug 1, 2023

Conversation

dzungtran89
Copy link
Contributor

@dzungtran89 dzungtran89 mentioned this pull request Mar 3, 2023
Open
2 tasks
Camille0907
Camille0907 reviewed Mar 3, 2023
View reviewed changes
Copy link
Contributor

@Camille0907 Camille0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check CI

@dzungtran89 dzungtran89 force-pushed the 16.0-mis_builder_budget_product branch from ad51514 to 4757598 Compare March 3, 2023 08:40
@dzungtran89
Copy link
Contributor Author

Hi @Camille0907 , I just pushed a PR for fixing the pre-commit #38

@dzungtran89 dzungtran89 force-pushed the 16.0-mis_builder_budget_product branch from 4757598 to 98d21eb Compare March 3, 2023 09:45
@dzungtran89 dzungtran89 force-pushed the 16.0-mis_builder_budget_product branch from 98d21eb to fbd1d83 Compare March 3, 2023 11:15
@StephaneMangin
Copy link

cc @dzungtran89 Seems like pre-commit still want to be fixed ;)

@dzungtran89 dzungtran89 force-pushed the 16.0-mis_builder_budget_product branch from fbd1d83 to 752a442 Compare March 27, 2023 07:29
@dzungtran89
Copy link
Contributor Author

dzungtran89 commented Mar 27, 2023 •
edited
Loading

cc @dzungtran89 Seems like pre-commit still want to be fixed ;)

@StephaneMangin thanks for the review, the PR has been updated, btw the migration of mis_builder_budget has already included in the pr of mis_builder by the author

@smussie
Copy link

smussie commented Jun 15, 2023

Hello @dzungtran89 I proposed a new PR in favor of this one #40

@dzungtran89 dzungtran89 force-pushed the 16.0-mis_builder_budget_product branch from 752a442 to e7f9c7a Compare June 16, 2023 03:59
@dzungtran89
Copy link
Contributor Author

dzungtran89 commented Jun 16, 2023 •
edited
Loading

Hello @dzungtran89 I proposed a new PR in favor of this one #40

Hello @smussie , thanks for PR, btw I'm willing to update my PR if you have any suggestions. I saw that your PR updated the position of company and product fields, so I could update my PR anw

@smussie smussie mentioned this pull request Jun 16, 2023
Closed
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@StephaneMangin
Copy link

Needed OCA/mis-builder#472 and already merged

@dzungtran89 dzungtran89 force-pushed the 16.0-mis_builder_budget_product branch from e7f9c7a to ee2d7c1 Compare July 19, 2023 10:39
@simahawk
Copy link

/ocabot migration mis_builder_budget_product

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 24, 2023
simahawk
simahawk reviewed Jul 24, 2023
View reviewed changes
Copy link

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non blocking remarks

mis_builder_budget_product/readme/newsfragments/32.feature Outdated Show resolved Hide resolved
@dzungtran89 dzungtran89 force-pushed the 16.0-mis_builder_budget_product branch from ee2d7c1 to 81ed622 Compare July 25, 2023 04:49
@simahawk
Copy link

simahawk commented Aug 1, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-36-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 15e97d6 into OCA:16.0 Aug 1, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bd12403. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Camille0907 Camille0907 Camille0907 approved these changes

@simahawk simahawk simahawk left review comments

@smussie smussie smussie approved these changes

@StephaneMangin StephaneMangin StephaneMangin approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@dzungtran89 @StephaneMangin @smussie @OCA-git-bot @simahawk @Camille0907