Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] mis_builder: bug unable to add SUM COL at once #457

Merged
merged 1 commit into from
Oct 11, 2022
Merged

[14.0][FIX] mis_builder: bug unable to add SUM COL at once #457

merged 1 commit into from
Oct 11, 2022

Conversation

alexis-via
Copy link
Contributor

Fixes bug #393. It's a hack, but it works well. I tried TONS of other solution (would take too much time to list them here), and it's the only solution I found.

Fix missing default value on company_id when creating a new report instance with default values

@alexis-via
[FIX] mis_builder: bug unable to add SUM COL at once
8d52278 
Fixes bug OCA#393 (it's a hack, but it works well)
Fix missing default value on company_id when creating a new report instance with default values
@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

@alexis-via alexis-via mentioned this pull request Aug 5, 2022
Closed
petrus-v
petrus-v approved these changes Oct 10, 2022
View reviewed changes
Copy link

@petrus-v petrus-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works like expected thanks for this fix.

I would love to see unit test to notice developer in case they remove it (by mistake) but won't lock as long issue is referenced !

Thanks a lot for your time

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@leemannd leemannd mentioned this pull request Oct 11, 2022
Merged
@sbidoul
Copy link
Member

sbidoul commented Oct 11, 2022

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-457-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 449604f into OCA:14.0 Oct 11, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1994032. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul mentioned this pull request Jan 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrus-v petrus-v petrus-v approved these changes

@rapvalencia rapvalencia rapvalencia approved these changes

Assignees
No one assigned
Labels
14.0 approved bugfix merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexis-via @OCA-git-bot @sbidoul @petrus-v @rapvalencia